[tor-bugs] #1848 [Tor Client]: many "warning: 'struct in_addr' declared inside parameter list" when compiled on OpenBSD 4.8

[Tor Bug Tracker & Wiki]

#1848: many "warning: 'struct in_addr' declared inside parameter list" when
compiled on OpenBSD 4.8
------------------------+---------------------------------------------------
 Reporter:  Tas         |       Owner:  arma               
     Type:  defect      |      Status:  accepted           
 Priority:  normal      |   Milestone:  Tor: 0.2.2.x-final 
Component:  Tor Client  |     Version:  Tor: 0.2.2.15-alpha
 Keywords:  easy        |      Parent:                     
------------------------+---------------------------------------------------

Comment(by nickm):

 The bug1848 branch looks ok to me; merging that.

 The attached pile of warnings, though, looks like some kind of crazy snafu
 with the openbsd source.  It should be totally legal to include stdlib.h
 and unistd.h and sys/types.h all from the same C source file, so I guess
 that maybe -Wredundant-decls just isn't going to be an option on OpenBSD
 4.8.  (Looking at the headers in http://www.openbsd.org/cgi-
 bin/cvsweb/src/include/ work, it really does seem that they declare these
 functions in multiple headers.)

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1848#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online