[tor-bugs] #1799 [arm]: arm chokes on tabs when used in ExitPolicy lines

[Tor Bug Tracker & Wiki]

#1799: arm chokes on tabs when used in ExitPolicy lines
--------------------+-------------------------------------------------------
 Reporter:  atagar  |       Owner:  atagar
     Type:  defect  |      Status:  new   
 Priority:  normal  |   Milestone:        
Component:  arm     |     Version:        
 Keywords:          |      Parent:        
--------------------+-------------------------------------------------------
Description changed by atagar:

Old description:

> voidzero reports that tabs in the ExitPolicy lines causes a variety of
> gremlins when determining the exit policy. This includes display issues
> when parsing the torrc and a crashing issue in the connection panel:
>    1.
>       Traceback (most recent call last):
>    2.
>         File "init/starter.py", line 178, in <module>
>    3.
>           interface.controller.startTorMonitor(expandedEvents,
> param["startup.blindModeEnabled"])
>    4.
>         File "/home/void/user/arm/interface/controller.py", line 1287, in
> startTorMonitor
>    5.
>           curses.wrapper(drawTorMonitor, loggedEvents, isBlindMode)
>    6.
>         File "/usr/lib/python2.6/curses/wrapper.py", line 44, in wrapper
>    7.
>           return func(stdscr, *args, **kwds)
>    8.
>         File "/home/void/user/arm/interface/controller.py", line 377, in
> drawTorMonitor
>    9.
>           panels["conn"] = connPanel.ConnPanel(stdscr, conn, isBlindMode)
>   10.
>         File "/home/void/user/arm/interface/connPanel.py", line 170, in
> __init__
>   11.
>           self.reset()
>   12.
>         File "/home/void/user/arm/interface/connPanel.py", line 336, in
> reset
>   13.
>           if SCRUB_PRIVATE_DATA and fIp not in
> self.fingerprintMappings.keys(): isPrivate = isExitAllowed(fIp, fPort,
> self.exitPolicy, self.exitRejectPrivate)
>   14.
>         File "/home/void/user/arm/interface/connPanel.py", line 893, in
> isExitAllowed
>   15.
>           maxPort = int(entryPort[entryPort.find("-") + 1:])
>   16.
>       ValueError: invalid literal for int() with base 10: '22"'

New description:

 voidzero reports that tabs in the ExitPolicy lines causes a variety of
 gremlins when determining the exit policy. This includes display issues
 when parsing the torrc and a crashing issue in the connection panel:
    1. Traceback (most recent call last):
    2. File "init/starter.py", line 178, in <module>
    3. interface.controller.startTorMonitor(expandedEvents,
 param["startup.blindModeEnabled"])
    4. File "/home/void/user/arm/interface/controller.py", line 1287, in
 startTorMonitor
    5. curses.wrapper(drawTorMonitor, loggedEvents, isBlindMode)
    6. File "/usr/lib/python2.6/curses/wrapper.py", line 44, in wrapper
    7. return func(stdscr, *args, **kwds)
    8. File "/home/void/user/arm/interface/controller.py", line 377, in
 drawTorMonitor
    9. panels["conn"] = connPanel.ConnPanel(stdscr, conn, isBlindMode)
   10. File "/home/void/user/arm/interface/connPanel.py", line 170, in
 __init__
   11. self.reset()
   12. File "/home/void/user/arm/interface/connPanel.py", line 336, in
 reset
   13. if SCRUB_PRIVATE_DATA and fIp not in
 self.fingerprintMappings.keys(): isPrivate = isExitAllowed(fIp, fPort,
 self.exitPolicy, self.exitRejectPrivate)
   14. File "/home/void/user/arm/interface/connPanel.py", line 893, in
 isExitAllowed
   15. maxPort = int(entryPort[entryPort.find("-") + 1:])
   16. ValueError: invalid literal for int() with base 10: '22"'

--

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1799#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online