[tor-bugs] #1746 [Tor - Relay]: Allow statistics options to be changed without restarting Tor

[Tor Bug Tracker & Wiki]

#1746: Allow statistics options to be changed without restarting Tor
-------------------------+--------------------------------------------------
 Reporter:  Sebastian    |       Owner:              
     Type:  defect       |      Status:  needs_review
 Priority:  normal       |   Milestone:              
Component:  Tor - Relay  |     Version:              
 Keywords:               |      Parent:              
-------------------------+--------------------------------------------------

Comment(by nickm):

 Reviewing now.  Some notes:

  * The geoip and rephist stats have gotten really complicated.  It would
 be good to have a list at the head of each file explaining what stats are
 stored there, and to have all the variables that relate to storing one
 kind of thing put together
  * Maybe we should use booleans to tell if stats collection types are
 initialized/running/whatever instead of doing stuff like
 {{{
 +  if (!start_of_entry_stats_interval)
 +    return 0; /* Not initialized. */
 }}}
  * I don't see what replaces the old "have N intervals of data per
 country" logic in per-country request counts, or why it's taken out.  What
 does that have to do with making the stats settings changeable?
  * When you're making a near-1000 line diff, it would be good if the
 commit message explained not only the intent of the change, but also the
 mechanism.  As it stands, I am trying to infer design from code, which
 shouldn't be necessary.
  * wrt the message "We are no longer acting as a bridge.  Forgetting GeoIP
 stats.", what code actually does that?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1746#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online