[tor-bugs] #1773 [Tor - Relay]: Use curly braces for variable expansion in makefiles.

Tor Bug Tracker & Wiki torproject-admin at torproject.org
Sun Aug 1 09:39:39 UTC 2010


#1773: Use curly braces for variable expansion in makefiles.
--------------------------+-------------------------------------------------
  Reporter:  ln5          |       Owner:  ln5     
      Type:  defect       |      Status:  reopened
  Priority:  minor        |   Milestone:          
 Component:  Tor - Relay  |     Version:          
Resolution:               |    Keywords:          
    Parent:               |  
--------------------------+-------------------------------------------------
Changes (by ln5):

  * status:  closed => reopened
  * resolution:  fixed =>


Comment:

 Replacing parentheses with curly braces didn't really cut it.

 What it takes is to change ':=' to '::='.
 GNU Make seems happy enough with this but Automake gets annoyed by it and
 omits a warning for every occurrence in Makefile.am:

   asciidoc_files:: non-POSIX variable name

 which is a bit misleading since it's not the variable _name_ it's upset
 about but rather the '::='.

 Appending a patch.  Let me know if we want this or if we rather should try
 to find some other way of doing this.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1773#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list