[tbb-commits] [Git][tpo/applications/tor-browser][tor-browser-115.12.0esr-13.5-1] fixup! Bug 40933: Add tor-launcher functionality

[Pier Angelo Vendrame (@pierov)]

Pier Angelo Vendrame pushed to branch tor-browser-115.12.0esr-13.5-1 at The Tor Project / Applications / Tor Browser


Commits:
1d8abcb1 by Pier Angelo Vendrame at 2024-06-12T16:01:14+02:00
fixup! Bug 40933: Add tor-launcher functionality

Bug 42636: A bad bridge line might get TBA stuck.

A while ago I reworked the relationship between TorSettings and
TorProvider. While doing so I was too strict, and a failure to push
settings during initialization will stop the initialization itself,
which will result in TBA stuck at the splash screen.

The problem appears also on desktop (the user will get a prompt that
asks to restart Tor, even though it is not perfect, see #21053).
However, on desktop the user can go to the settings and deleting the
bridges from there (which is not an optimal experience anyway).

- - - - -


1 changed file:

- toolkit/components/tor-launcher/TorProvider.sys.mjs


Changes:

=====================================
toolkit/components/tor-launcher/TorProvider.sys.mjs
=====================================
@@ -232,11 +232,9 @@ export class TorProvider {
         await this.writeSettings(lazy.TorSettings.getSettings());
       } catch (e) {
         logger.warn(
-          "Failed to initialize TorSettings or to write our settings, so uninitializing.",
+          "Failed to initialize TorSettings or to write our initial settings. Continuing the initialization anyway.",
           e
         );
-        this.uninit();
-        throw e;
       }
     }
 



View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/1d8abcb1f7a7543237f29b6ef3f38a16bf06e3ae

-- 
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/1d8abcb1f7a7543237f29b6ef3f38a16bf06e3ae
You're receiving this email because of your account on gitlab.torproject.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.torproject.org/pipermail/tbb-commits/attachments/20240612/05119b63/attachment.htm>