[tbb-commits] [Git][tpo/applications/firefox-android][firefox-android-115.2.1-13.0-1] fixup! Bug 42089: Remove ability to submit site support requests

Dan Ballard (@dan) git at gitlab.torproject.org
Fri Sep 22 00:30:09 UTC 2023



Dan Ballard pushed to branch firefox-android-115.2.1-13.0-1 at The Tor Project / Applications / firefox-android


Commits:
296e0aaa by Dan Ballard at 2023-09-21T17:27:09-07:00
fixup! Bug 42089: Remove ability to submit site support requests

bug 42089: remove comments, glean is sad, and this code will never be referenced

- - - - -


2 changed files:

- fenix/app/metrics.yaml
- fenix/app/pings.yaml


Changes:

=====================================
fenix/app/metrics.yaml
=====================================
@@ -7738,62 +7738,62 @@ cookie_banners:
     metadata:
       tags:
         - Privacy&Security
-#  report_site_domain:
-#    type: url
-#    description: |
-#      A user can report a site domain(Ex. for https://edition.cnn.com/
-#      site domain will be cnn.com) when the cookie banner reducer is not
-#      working from the cookie banner details panel.
-#    lifetime: ping
-#    send_in_pings:
-#      - cookie-banner-report-site
-#    bugs:
-#      - https://bugzilla.mozilla.org/show_bug.cgi?id=1805450
-#    data_reviews:
-#      - https://github.com/mozilla-mobile/firefox-android/pull/1298#pullrequestreview-1350344223
-#    data_sensitivity:
-#      - technical
-#      - interaction
-#    notification_emails:
-#      - android-probes at mozilla.com
-#    expires: 119
-#    metadata:
-#      tags:
-#        - Privacy&Security
-#  report_site_cancel_button:
-#    type: event
-#    description: |
-#      The user has pressed the report site domain cancel button
-#      from the cookie banner reducer details panel.
-#    bugs:
-#      - https://bugzilla.mozilla.org/show_bug.cgi?id=1805450
-#    data_reviews:
-#      - https://github.com/mozilla-mobile/firefox-android/pull/1298#pullrequestreview-1350344223
-#    data_sensitivity:
-#      - interaction
-#    notification_emails:
-#      - android-probes at mozilla.com
-#    expires: 119
-#    metadata:
-#      tags:
-#        - Privacy&Security
-#  report_domain_site_button:
-#    type: event
-#    description: |
-#      The user has pressed the report site domain button
-#      from the cookie banner reducer details panel.
-#    bugs:
-#      - https://bugzilla.mozilla.org/show_bug.cgi?id=1805450
-#    data_reviews:
-#      - https://github.com/mozilla-mobile/firefox-android/pull/1298#pullrequestreview-1350344223
-#    data_sensitivity:
-#      - interaction
-#    notification_emails:
-#      - android-probes at mozilla.com
-#    expires: 119
-#    metadata:
-#      tags:
-#        - Privacy&Security
+  report_site_domain:
+    type: url
+    description: |
+      A user can report a site domain(Ex. for https://edition.cnn.com/
+      site domain will be cnn.com) when the cookie banner reducer is not
+      working from the cookie banner details panel.
+    lifetime: ping
+    send_in_pings:
+      - cookie-banner-report-site
+    bugs:
+      - https://bugzilla.mozilla.org/show_bug.cgi?id=1805450
+    data_reviews:
+      - https://github.com/mozilla-mobile/firefox-android/pull/1298#pullrequestreview-1350344223
+    data_sensitivity:
+      - technical
+      - interaction
+    notification_emails:
+      - android-probes at mozilla.com
+    expires: 119
+    metadata:
+      tags:
+        - Privacy&Security
+  report_site_cancel_button:
+    type: event
+    description: |
+      The user has pressed the report site domain cancel button
+      from the cookie banner reducer details panel.
+    bugs:
+      - https://bugzilla.mozilla.org/show_bug.cgi?id=1805450
+    data_reviews:
+      - https://github.com/mozilla-mobile/firefox-android/pull/1298#pullrequestreview-1350344223
+    data_sensitivity:
+      - interaction
+    notification_emails:
+      - android-probes at mozilla.com
+    expires: 119
+    metadata:
+      tags:
+        - Privacy&Security
+  report_domain_site_button:
+    type: event
+    description: |
+      The user has pressed the report site domain button
+      from the cookie banner reducer details panel.
+    bugs:
+      - https://bugzilla.mozilla.org/show_bug.cgi?id=1805450
+    data_reviews:
+      - https://github.com/mozilla-mobile/firefox-android/pull/1298#pullrequestreview-1350344223
+    data_sensitivity:
+      - interaction
+    notification_emails:
+      - android-probes at mozilla.com
+    expires: 119
+    metadata:
+      tags:
+        - Privacy&Security
 
 site_permissions:
   prompt_shown:


=====================================
fenix/app/pings.yaml
=====================================
@@ -65,15 +65,15 @@ spoc:
   notification_emails:
     - android-probes at mozilla.com
 
-#cookie-banner-report-site:
-#  description: |
-#    This ping is needed when the cookie banner reducer doesn't work on
-#    a website, and the user wants to report the site.
-#    This ping doesn't include a client id.
-#  include_client_id: false
-#  bugs:
-#    - https://bugzilla.mozilla.org/show_bug.cgi?id=1805450
-#  data_reviews:
-#    - https://github.com/mozilla-mobile/firefox-android/pull/1298#pullrequestreview-1350344223
-#  notification_emails:
-#    - android-probes at mozilla.com
+cookie-banner-report-site:
+  description: |
+    This ping is needed when the cookie banner reducer doesn't work on
+    a website, and the user wants to report the site.
+    This ping doesn't include a client id.
+  include_client_id: false
+  bugs:
+    - https://bugzilla.mozilla.org/show_bug.cgi?id=1805450
+  data_reviews:
+    - https://github.com/mozilla-mobile/firefox-android/pull/1298#pullrequestreview-1350344223
+  notification_emails:
+    - android-probes at mozilla.com



View it on GitLab: https://gitlab.torproject.org/tpo/applications/firefox-android/-/commit/296e0aaa31971ccd3d1e296230665c75ca397d49

-- 
View it on GitLab: https://gitlab.torproject.org/tpo/applications/firefox-android/-/commit/296e0aaa31971ccd3d1e296230665c75ca397d49
You're receiving this email because of your account on gitlab.torproject.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.torproject.org/pipermail/tbb-commits/attachments/20230922/3ae5d87d/attachment-0001.htm>


More information about the tbb-commits mailing list