[tbb-commits] [Git][tpo/applications/tor-browser][tor-browser-102.7.0esr-12.5-1] 5 commits: dropme! Partial revert of "Bug 10760: Integrate TorButton to TorBrowser core"

[Pier Angelo Vendrame (@pierov)]

Pier Angelo Vendrame pushed to branch tor-browser-102.7.0esr-12.5-1 at The Tor Project / Applications / Tor Browser


Commits:
feffd625 by Henry Wilkes at 2023-02-08T10:21:04+00:00
dropme! Partial revert of "Bug 10760: Integrate TorButton to TorBrowser core"

Bug 41609: Revert the activity stream changes.

- - - - -
6cd4fa5a by Henry Wilkes at 2023-02-08T10:21:05+00:00
fixup! Firefox preference overrides.

Bug 41609: Set home page and new tab to about:blank in base-browser.

- - - - -
ed354cc8 by Henry Wilkes at 2023-02-08T10:21:38+00:00
Bug 31575: Disable Firefox Home (Activity Stream)

Treat about:blank as the default home page and new tab page.

Avoid loading AboutNewTab in BrowserGlue.jsm in order
to avoid several network requests that we do not need.

- - - - -
6793375e by Henry Wilkes at 2023-02-08T10:22:35+00:00
fixup! Bug 10760: Integrate TorButton to TorBrowser core

Bug 41609: Change the default home page from about:blank to about:tor

- - - - -
93a409f1 by Henry Wilkes at 2023-02-08T10:22:36+00:00
amend! Bug 10760: Integrate TorButton to TorBrowser core

Bug 10760: Integrate TorButton to TorBrowser core

Because of the non-restartless nature of Torbutton, it required
a two-stage installation process. On mobile, it was a problem,
because it was not loading when the user opened the browser for
the first time.

Moving it to tor-browser and making it a system extension allows it
to load when the user opens the browser for first time.

Additionally, this patch also fixes Bug 27611.

Bug 26321: New Circuit and New Identity menu items

Bug 14392: Make about:tor behave like other initial pages.

Bug 25013: Add torbutton as a tor-browser submodule

Bug 31575: Replace Firefox Home (newtab) with about:tor

- - - - -


3 changed files:

- browser/app/profile/001-base-profile.js
- browser/components/BrowserGlue.jsm
- browser/components/preferences/home.js


Changes:

=====================================
browser/app/profile/001-base-profile.js
=====================================
@@ -4,6 +4,11 @@
 // Use the OS locale by default (tor-browser#17400)
 pref("intl.locale.requested", "");
 
+// Home page and new tab is blank rather than Firefox Home (Activity Stream).
+// tor-browser#31575 and tor-browser#30662
+pref("browser.startup.homepage", "about:blank");
+pref("browser.newtabpage.enabled", false);
+
 // Disable initial homepage notifications
 pref("browser.search.update", false);
 pref("startup.homepage_welcome_url", "");
@@ -151,7 +156,6 @@ pref("services.sync.engine.passwords", false);
 pref("services.sync.engine.prefs", false);
 pref("services.sync.engine.tabs", false);
 pref("extensions.getAddons.cache.enabled", false); // https://blog.mozilla.org/addons/how-to-opt-out-of-add-on-metadata-updates/
-pref("browser.newtabpage.enabled", false);
 pref("browser.search.region", "US"); // The next two prefs disable GeoIP search lookups (#16254)
 pref("browser.search.geoip.url", "");
 pref("browser.fixup.alternate.enabled", false); // Bug #16783: Prevent .onion fixups


=====================================
browser/components/BrowserGlue.jsm
=====================================
@@ -5899,7 +5899,7 @@ var AboutHomeStartupCache = {
       return { pageInputStream: null, scriptInputStream: null };
     }
 
-    this.log.error("Activity Stream is disabled in Tor Browser.");
+    this.log.error("Activity Stream is disabled.");
     return { pageInputStream: null, scriptInputStream: null };
   },
 


=====================================
browser/components/preferences/home.js
=====================================
@@ -380,10 +380,14 @@ var gHomePane = {
 
     if (controllingExtension && controllingExtension.id) {
       newValue = controllingExtension.id;
-    } else if (isDefault) {
-      newValue = this.HOME_MODE_FIREFOX_HOME;
     } else if (isBlank) {
+      // For base-browser, we want to check isBlank first since the default page
+      // is also the blank page, but we only have a menu option for
+      // HOME_MODE_BLANK, rather than HOME_MODE_FIREFOX_HOME.
+      // See tor-browser#41609.
       newValue = this.HOME_MODE_BLANK;
+    } else if (isDefault) {
+      newValue = this.HOME_MODE_FIREFOX_HOME;
     } else {
       newValue = this.HOME_MODE_CUSTOM;
     }



View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/1ac8520e83901abb1d1f57b8752b7f1aad58a3a4...93a409f1321d07b2cea869834da8ddcf4d16a357

-- 
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/1ac8520e83901abb1d1f57b8752b7f1aad58a3a4...93a409f1321d07b2cea869834da8ddcf4d16a357
You're receiving this email because of your account on gitlab.torproject.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.torproject.org/pipermail/tbb-commits/attachments/20230208/dcbb17fe/attachment-0001.htm>