[tbb-commits] [Git][tpo/applications/tor-browser][tor-browser-115.6.0esr-13.5-1] fixup! Bug 23247: Communicating security expectations for .onion

[Pier Angelo Vendrame (@pierov)]

Pier Angelo Vendrame pushed to branch tor-browser-115.6.0esr-13.5-1 at The Tor Project / Applications / Tor Browser


Commits:
56ae0dfc by Pier Angelo Vendrame at 2023-12-13T16:55:36+01:00
fixup! Bug 23247: Communicating security expectations for .onion

Bug 42334: Adapt our self-signed patch to Bug 1611381

Bug 1611381 introduced a few changes to catch more self-signed
certificates. As a result, we risk of accepting some cases different
than unknown issuer for .onion certificates, such as bad signature or
invalid use for a certificate.

It makes sense to still display an error for such cases, and to keep
accepting only unknown issuers.

- - - - -


1 changed file:

- security/certverifier/CertVerifier.cpp


Changes:

=====================================
security/certverifier/CertVerifier.cpp
=====================================
@@ -865,12 +865,15 @@ Result CertVerifier::VerifySSLServerCert(
       // find other certificates with the same subject but different keys, and
       // the certificate is self-signed.
       if (StringEndsWith(hostname, ".onion"_ns)) {
-        // Self signed cert over onion is deemed secure, the hidden service
-        // provides authentication. We defer returning this error and keep
-        // processing to determine if there are other legitimate certificate
-        // errors (such as expired, wrong domain) that we would like to surface
-        // to the user
-        errOnionWithSelfSignedCert = true;
+        // Self signed cert over onion is deemed secure in some cases, as the
+        // onion service provides encryption.
+        // Firefox treats some errors as self-signed certificates and it allows
+        // to override them. For Onion services, we prefer being stricter, and
+        // we return the original errors.
+        // Moreover, we need also to determine if there are other legitimate
+        // certificate errors (such as expired, wrong domain) that we would like
+        // to surface to the user.
+        errOnionWithSelfSignedCert = rv == Result::ERROR_UNKNOWN_ISSUER;
       } else {
         return Result::ERROR_SELF_SIGNED_CERT;
       }



View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/56ae0dfce8c30c43d5316ad1f4aff638dee5f9dc

-- 
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/56ae0dfce8c30c43d5316ad1f4aff638dee5f9dc
You're receiving this email because of your account on gitlab.torproject.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.torproject.org/pipermail/tbb-commits/attachments/20231213/8ac929e6/attachment-0001.htm>