[tbb-commits] [torbutton/maint-10.0] Switch DDG search on homepage from POST to GET

sysrqb at torproject.org sysrqb at torproject.org
Tue Feb 16 22:42:12 UTC 2021


commit 74d22e9cc3cd29bc5f676ffb17bfd3c05c59081a
Author: Peter Story <pstory at andrew.cmu.edu>
Date:   Mon Jan 11 13:56:54 2021 -0500

    Switch DDG search on homepage from POST to GET
    
    See tor-browser#40287
    
    Also, eliminate extra "b" parameter from the search form. The
    presence of "b" would reveal that the search was initiated from
    the landing page, rather than the urlbar.
---
 chrome/content/aboutTor/aboutTor.xhtml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/chrome/content/aboutTor/aboutTor.xhtml b/chrome/content/aboutTor/aboutTor.xhtml
index fdc02593..a5ef1f1c 100644
--- a/chrome/content/aboutTor/aboutTor.xhtml
+++ b/chrome/content/aboutTor/aboutTor.xhtml
@@ -53,12 +53,12 @@
     </div>
 
     <div class="searchbox hideIfTorOff"> <!-- begin form based search -->
-      <form action="&aboutTor.searchDDGPost.link;" method="post">
+      <form action="&aboutTor.searchDDGPost.link;" method="get">
         <div class="searchwrapper">
           <label class="searchlabel" for="search-text"> </label>
           <input name="q" id="search-text" placeholder="&aboutTor.search.label;"
                  autocomplete="off" type="text"/>
-          <input name="b" id="search-button" value=""
+          <input id="search-button" value=""
                  title="&aboutTor.search.label;"
                  alt="&aboutTor.search.label;" type="submit"/>
         </div>



More information about the tbb-commits mailing list