[tbb-commits] [tor-browser/tor-browser-68.5.0esr-9.5-1] Revert "Bug 1603270 - Add telemetry for FirefoxPromoBannerRow user actions. r=VladBaicu, a=RyanVM"

sysrqb at torproject.org sysrqb at torproject.org
Tue Feb 11 20:47:00 UTC 2020


commit c2da27fca068dac7658fe53f51124908ee8c723b
Author: Matthew Finkel <Matthew.Finkel at gmail.com>
Date:   Tue Feb 11 20:41:06 2020 +0000

    Revert "Bug 1603270 - Add telemetry for FirefoxPromoBannerRow user actions. r=VladBaicu, a=RyanVM"
    
    This reverts commit 334f572f8b2113c464bd65e1282b7085a1dfb5eb.
---
 mobile/android/base/java/org/mozilla/gecko/Telemetry.java       | 9 ---------
 mobile/android/base/java/org/mozilla/gecko/mma/MmaDelegate.java | 2 --
 2 files changed, 11 deletions(-)

diff --git a/mobile/android/base/java/org/mozilla/gecko/Telemetry.java b/mobile/android/base/java/org/mozilla/gecko/Telemetry.java
index 4da174d18bb9..20a50a0bd34b 100644
--- a/mobile/android/base/java/org/mozilla/gecko/Telemetry.java
+++ b/mobile/android/base/java/org/mozilla/gecko/Telemetry.java
@@ -5,7 +5,6 @@
 
 package org.mozilla.gecko;
 
-import org.mozilla.gecko.activitystream.homepanel.stream.FirefoxPromoBannerRow;
 import org.mozilla.gecko.annotation.RobocopTarget;
 import org.mozilla.gecko.annotation.WrapForJNI;
 import org.mozilla.gecko.TelemetryContract.Event;
@@ -16,10 +15,8 @@ import org.mozilla.gecko.mma.MmaDelegate;
 
 import android.util.Log;
 
-import static org.mozilla.gecko.mma.MmaDelegate.DISMISSED_FIREFOX_PROMO_BANNER;
 import static org.mozilla.gecko.mma.MmaDelegate.INTERACT_WITH_SEARCH_URL_AREA;
 import static org.mozilla.gecko.mma.MmaDelegate.OPENED_BOOKMARK;
-import static org.mozilla.gecko.mma.MmaDelegate.OPENED_FIREFOX_PROMO_BANNER;
 import static org.mozilla.gecko.mma.MmaDelegate.SAVED_BOOKMARK;
 import static org.mozilla.gecko.mma.MmaDelegate.SAVED_LOGIN_AND_PASSWORD;
 import static org.mozilla.gecko.mma.MmaDelegate.SCREENSHOT;
@@ -111,12 +108,6 @@ public class Telemetry {
             MmaDelegate.track(SAVED_LOGIN_AND_PASSWORD);
         } else if (eventName.equalsIgnoreCase(Event.ACTION.toString()) && method == Method.BUTTON && extras.equals("awesomescreen-signup-dismiss")) {
             MmaDelegate.track(SIGN_UP_DISMISS);
-        } else if (eventName.equalsIgnoreCase(Event.ACTION.toString()) && method == Method.BUTTON &&
-                extras.equals(FirefoxPromoBannerRow.FIREFOX_PROMO_OPEN_EVENT)) {
-            MmaDelegate.track(OPENED_FIREFOX_PROMO_BANNER);
-        } else if (eventName.equalsIgnoreCase(Event.ACTION.toString()) && method == Method.BUTTON &&
-                extras.equals(FirefoxPromoBannerRow.FIREFOX_PROMO_DISMISS_EVENT)) {
-            MmaDelegate.track(DISMISSED_FIREFOX_PROMO_BANNER);
         }
     }
 }
diff --git a/mobile/android/base/java/org/mozilla/gecko/mma/MmaDelegate.java b/mobile/android/base/java/org/mozilla/gecko/mma/MmaDelegate.java
index f4a3e926afc3..68a36a65026c 100644
--- a/mobile/android/base/java/org/mozilla/gecko/mma/MmaDelegate.java
+++ b/mobile/android/base/java/org/mozilla/gecko/mma/MmaDelegate.java
@@ -55,8 +55,6 @@ public class MmaDelegate {
     public static final String ONBOARDING_DEFAULT_VALUES = "E_Onboarding_With_Default_Values";
     public static final String ONBOARDING_REMOTE_VALUES = "E_Onboarding_With_Remote_Values";
     public static final String SIGN_UP_DISMISS = "E_Signup_Dismiss";
-    public static final String OPENED_FIREFOX_PROMO_BANNER = "E_Opened_Firefox_Promo";
-    public static final String DISMISSED_FIREFOX_PROMO_BANNER = "E_Dismissed_Firefox_Promo";
 
     public static final String USER_SIGNED_IN_TO_FXA = "E_User_Signed_In_To_FxA";
     public static final String USER_SIGNED_UP_FOR_FXA = "E_User_Signed_Up_For_FxA";



More information about the tbb-commits mailing list