[tbb-commits] [tor-browser/tor-browser-45.2.0esr-6.5-1] Revert "Bug 1229855: Fix miscompilation of uint8_t enum class with gcc4.8.2; r=luke a=lizzard"

gk at torproject.org gk at torproject.org
Fri Jun 17 13:39:14 UTC 2016


commit 2fbfb9d9af2553b35ec9231f3923b3be49ab2549
Author: Georg Koppen <gk at torproject.org>
Date:   Fri Jun 17 13:38:23 2016 +0000

    Revert "Bug 1229855: Fix miscompilation of uint8_t enum class with gcc4.8.2; r=luke a=lizzard"
    
    This reverts commit fcb31773712f1e2adce790771f7978ba30056645.
    
    This fixes bug 19400. We are not affected by a buggy GCC 4.8.2.
---
 js/src/asmjs/Wasm.h | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/js/src/asmjs/Wasm.h b/js/src/asmjs/Wasm.h
index b0976d0..2777467 100644
--- a/js/src/asmjs/Wasm.h
+++ b/js/src/asmjs/Wasm.h
@@ -34,9 +34,7 @@ using mozilla::Move;
 // The ValType enum represents the WebAssembly "value type", which are used to
 // specify the type of locals and parameters.
 
-// FIXME: uint8_t would make more sense for the underlying storage class, but
-// causes miscompilations in GCC (fixed in 4.8.5 and 4.9.3).
-enum class ValType
+enum class ValType : uint8_t
 {
     I32,
     I64,



More information about the tbb-commits mailing list