[tbb-commits] [tor-browser-bundle/master] Bug 4261: Fix DMG permissions to work from /Applications

mikeperry at torproject.org mikeperry at torproject.org
Sat Mar 8 21:48:05 UTC 2014


commit fb9453c51306ad39d261617e2cb3ba8e18368574
Author: Mike Perry <mikeperry-git at torproject.org>
Date:   Sat Mar 8 13:46:23 2014 -0800

    Bug 4261: Fix DMG permissions to work from /Applications
    
    Only seems to matter on some Mac versions... Very odd.
---
 gitian/build-helpers/ddmg.sh |    9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/gitian/build-helpers/ddmg.sh b/gitian/build-helpers/ddmg.sh
index 468d6be..c37a1fd 100755
--- a/gitian/build-helpers/ddmg.sh
+++ b/gitian/build-helpers/ddmg.sh
@@ -5,14 +5,17 @@ export LC_ALL=C
 DMGFILE=$1
 shift
 
-find $@ -executable -exec chmod 700 {} \;
-find $@ ! -executable -exec chmod 600 {} \;
+# We need group readability for some Macs to be able to handle /Applications
+# installation. Still unclear exactly why this is -- it is not dependent on
+# OSX version...
+find $@ -executable -exec chmod 750 {} \;
+find $@ ! -executable -exec chmod 640 {} \;
 
 cd $@
 find . -type f | sed -e 's/^\.\///' | sort | xargs -i echo "{}={}" > ~/build/filelist.txt
 find . -type l | sed -e 's/^\.\///' | sort | xargs -i echo "{}={}" >> ~/build/filelist.txt
 
-mkisofs -D -V "Tor Browser" -no-pad -R -apple -o ~/build/tbb-uncompressed.dmg -path-list ~/build/filelist.txt -graft-points -dir-mode 0700 -new-dir-mode 0700
+mkisofs -D -V "Tor Browser" -no-pad -R -apple -o ~/build/tbb-uncompressed.dmg -path-list ~/build/filelist.txt -graft-points -gid 20 -dir-mode 0750 -new-dir-mode 0750
 
 cd ~/build
 



More information about the tbb-commits mailing list