[tbb-commits] [tor-browser/esr24] Bug 991981 - Followup fix for ESR24 to properly init TypedArray structs using the provided obj in the constructor, rather than requiring Init to be called after construction. r=bz, a=bustage

mikeperry at torproject.org mikeperry at torproject.org
Fri Aug 29 05:26:41 UTC 2014


commit f7c724ad36208605421c24caac2ef8eef7b0860e
Author: Jeff Walden <jwalden at mit.edu>
Date:   Mon Jun 2 17:45:05 2014 -0700

    Bug 991981 - Followup fix for ESR24 to properly init TypedArray structs using the provided obj in the constructor, rather than requiring Init to be called after construction.  r=bz, a=bustage
---
 dom/bindings/TypedArray.h |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/dom/bindings/TypedArray.h b/dom/bindings/TypedArray.h
index c7c2bbd..62343c2 100644
--- a/dom/bindings/TypedArray.h
+++ b/dom/bindings/TypedArray.h
@@ -24,12 +24,12 @@ template<typename T,
          void GetLengthAndData(JSObject*, uint32_t*, T**)>
 struct TypedArray_base {
   TypedArray_base(JSObject* obj)
-    : mObj(obj),
+    : mObj(NULL),
       mData(NULL),
       mLength(0),
       mComputed(false)
   {
-    MOZ_ASSERT(obj != NULL);
+    Init(obj);
   }
 
 private:





More information about the tbb-commits mailing list