[tbb-bugs] #28766 [Applications/Tor Browser]: Tor Build for Android

[Tor Bug Tracker & Wiki]

#28766: Tor Build for Android
-------------------------------------------------+-------------------------
 Reporter:  sisbell                              |          Owner:  sisbell
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-mobile, tbb-rbm, tbb-parity,     |  Actual Points:
  TorBrowserTeam202002                           |
Parent ID:  #28704                               |         Points:  1
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by sysrqb):

 * status:  assigned => needs_revision


Comment:

 {{{
 -cp $distdir/share/tor/geoip $TORCONFIGDIR
 -cp $distdir/share/tor/geoip6 $TORCONFIGDIR
 -
 +[% IF !c("var/android") -%]
 +  cp $distdir/share/tor/geoip $TORCONFIGDIR
 +  cp $distdir/share/tor/geoip6 $TORCONFIGDIR
 +[% END -%]
 }}}
 Can you set `TORCONFIGDIR=assets/common` and use the original code
 instead?

 In the build script, please use `install` instead of `cp` (see how files
 are copied within the other platform blocks).

 {{{
 +[% IF c("var/android") %]
 +  libsdir=jniLibs/[% c("var/abi") %]
 +  mkdir -p $libsdir assets/common
 +  # Copy tor using naming convention that Android will recognize
 +  cp bin/tor $libsdir/libTor.so
 }}}
 There's a trailing space after 'recognize'

 Can you move the `tar` command into the general platform-specific tar/zip
 block that immediately follows the android block?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28766#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online