[tbb-bugs] #33954 [Applications/Tor Browser]: Consider different approach for "2176: Rebrand Firefox to TorBrowser "

[Tor Bug Tracker & Wiki]

#33954: Consider different approach for "2176: Rebrand Firefox to TorBrowser "
-------------------------------------+-------------------------------------
     Reporter:  acat                 |      Owner:  tbb-team
         Type:  defect               |     Status:  new
     Priority:  Medium               |  Milestone:
    Component:  Applications/Tor     |    Version:
  Browser                            |   Keywords:  ReleaseTrainMigration,
     Severity:  Normal               |  TorBrowserTeam202004
Actual Points:                       |  Parent ID:
       Points:                       |   Reviewer:
      Sponsor:  Sponsor58            |
-------------------------------------+-------------------------------------
 The current patch replaces all occurrences of `branding/brand.ftl` with
 `branding/tor-browser-brand.ftl`. This means that many files are touched
 by the patch (increasing chances of rebase conflict), and whenever Firefox
 adds new instances of `branding/brand.ftl` we need to modify the patch to
 also cover those.

 I think we should try a different approach to keep all instances of
 `branding/brand.ftl` untouched, and do the `branding/brand.ftl` ->
 `branding/tor-browser-brand.ftl` remapping somewhere else, and just in a
 single place.

 One way would be to force the Fluent `FileSource` that we register in
 torbutton to take precedence over any other source and rename `tor-
 browser-brand.ftl` to `brand.ftl`, to override Firefox one (including
 langpacks).

 We probably would need to do this in [https://searchfox.org/mozilla-
 central/rev/3446310d6cc5c85cde16a82eccf560e9b71a3d44/intl/l10n/L10nRegistry.jsm#141
 L10nRegistry.js], but I would need to investigate a bit more.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33954>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online