[tbb-bugs] #30429 [Applications/Tor Browser]: Rebase Tor Browser patches for Firefox ESR 68

[Tor Bug Tracker & Wiki]

#30429: Rebase Tor Browser patches for Firefox ESR 68
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  task                                 |         Status:
                                                 |  needs_review
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  ff68-esr, tbb-9.0-must-alpha,        |  Actual Points:
  TorBrowserTeam201909R                          |
Parent ID:                                       |         Points:  1
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor44-can
-------------------------------------------------+-------------------------
Changes (by acat):

 * keywords:  ff68-esr, tbb-9.0-must-alpha, TorBrowserTeam201909 =>
     ff68-esr, tbb-9.0-must-alpha, TorBrowserTeam201909R
 * status:  needs_revision => needs_review


Comment:

 Fixed in https://github.com/acatarineu/tor-browser/commits/30429+11. I
 also changed the last check for the `.onion` case to `if ((mState &
 STATE_IS_SECURE) == 0) {`, because I think the previous `if (mState !=
 STATE_IS_INSECURE) {` may have erased some flags in case of a https onion.

 I changed the comment, but not completely sure if you meant that or
 something else :)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30429#comment:74>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online