[tbb-bugs] #27601 [Applications/Tor Browser]: browser notifications are not working anymore with Tor Browser 8

[Tor Bug Tracker & Wiki]

#27601: browser notifications are not working anymore with Tor Browser 8
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:  closed
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:  fixed
 Keywords:  tbb-8.0-issues, tbb-regression,      |  Actual Points:
  tbb-8.0.1-can, tbb-9.0-must-alpha,             |
  TorBrowserTeam201909R                          |
Parent ID:                                       |         Points:  0.5
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:21 acat]:

 [snip]

 > So, given that we are hiding/disabling content blocking for now (and in
 principle are not affected by that regression) should we postpone
 backporting this patch until we explore/decide enabling content blocking?
 If yes, perhaps we could update #30939 so that we remember to backport
 this.

 That looks like a good idea. I am interested in seeing
 https://bugzilla.mozilla.org/show_bug.cgi?id=1554805 in 9.0, too. The
 proposed patches are not really big and are probably straightforward to
 apply. I'd wait a bit, though, until they have actually landed. I've
 created #31811 to keep track of that.

 > The first two are backported here: https://github.com/acatarineu/tor-
 browser/commits/27601.

 Those look good and I cherry-picked them onto `tor-
 browser-68.1.0esr-9.0-2` (commit c6eb1efb7d3ca6a9b5e19f6ec352ee1b129efbd3
 and f970a6e8a14d8f80f15be22fa1ed6b091b4d596b).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27601#comment:22>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online