[tbb-bugs] #31992 [Applications/Tor Browser]: Remove apktool workaround in #31564

[Tor Bug Tracker & Wiki]

#31992: Remove apktool workaround in #31564
--------------------------------------+--------------------------
 Reporter:  gk                        |          Owner:  tbb-team
     Type:  defect                    |         Status:  new
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  tbb-rbm                   |  Actual Points:
Parent ID:                            |         Points:  0.25
 Reviewer:                            |        Sponsor:
--------------------------------------+--------------------------

Comment (by sisbell):

 Replying to [comment:8 sysrqb]:
 > Replying to [comment:7 sisbell]:
 > > Replying to [comment:6 gk]:
 > > In the downloaded deb we see
 > >
 > >
 > > {{{
 > >  apktool depends on libsmali-java (>= 2.2.1); however:
 > > }}}
 > >
 > > If we can download 2.3 for these dependencies, it should work
 >
 > Can we use apt pinning like eighhave
 [https://trac.torproject.org/projects/tor/ticket/31564#comment:60
 suggested]? There's no reason why we should resolve the dependencies
 ourselves.

 Initially, this was the approach I was taking but with openjdk, I ran into
 various issues with pinning (see #31130). bolkm suggestion was to just
 download and install deb and packages directly. So far this is looking
 cleaner and I'm implementing now for openjdk. I'd like to keep the same
 approach with apktool and openjdk, if possible.

 >
 > > >
 > > > 2) I am a bit confused about the approach of picking a newer
 `apktool` .deb in the face of Debian's [https://bugs.debian.org/cgi-
 bin/bugreport.cgi?bug=942019 bug 942019]. How would that .deb work around
 the problem mentioned there?https://packages.debian.org/sid/apktool
 > >
 > > Given the one from the internet works and the one in buster doesn't,
 it is unlikely to have anything to do with aapt itself (which is the same
 in both cases), as suggested in the bugreport.
 >
 > It seems like there was already an upstream bugreport which was closed
 as not-a-bug.
 > https://github.com/iBotPeaches/Apktool/issues/2149
 >
 > But I don't know enough to say where the bug is.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31992#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online