[tbb-bugs] #31992 [Applications/Tor Browser]: Remove apktool workaround in #31564

[Tor Bug Tracker & Wiki]

#31992: Remove apktool workaround in #31564
--------------------------------------+--------------------------
 Reporter:  gk                        |          Owner:  tbb-team
     Type:  defect                    |         Status:  new
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  tbb-rbm                   |  Actual Points:
Parent ID:                            |         Points:  0.25
 Reviewer:                            |        Sponsor:
--------------------------------------+--------------------------

Comment (by sisbell):

 Replying to [comment:6 gk]:
 > Okay, so two questions here:
 >
 > 1) I've been skimming the comments in #31564 again but did not find an
 answer to my first question in comment:29:ticket:31564: Do we know whether
 apktool 2.3.4 that comes natively with Buster works or not?
 The one in buster wasn't working when I tried. It listed as 2.3.4 but all
 of the dependencies were much older 2.2, so I suspect the packaging was
 wrong, it wasn't really updated to 2.3.x.

 In the downloaded deb we see


 {{{
  apktool depends on libsmali-java (>= 2.2.1); however:
 }}}

 If we can download 2.3 for these dependencies, it should work

  https://github.com/iBotPeaches/Apktool/issues/1399 gives conflicting
 information. If it does work there is no need to do some `aptktool`
 related gymnastics here.
 >
 > 2) I am a bit confused about the approach of picking a newer `apktool`
 .deb in the face of Debian's [bug 942019 https://bugs.debian.org/cgi-
 bin/bugreport.cgi?bug=942019]. How would that .deb work around the problem
 mentioned there?

 Given the one from the internet works and the one in buster doesn't, it is
 unlikely to have anything to do with aapt itself (which is the same in
 both cases), as suggested in the bugreport.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31992#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online