[tbb-bugs] #27511 [Applications/Tor Browser]: Add New identity button to toolbar

[Tor Bug Tracker & Wiki]

#27511: Add New identity button to toolbar
-------------------------------------------------+-------------------------
 Reporter:  isnaiter                             |          Owner:  tbb-
                                                 |  team
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  ux-team, tbb-newnym, tbb-9.0-must-   |  Actual Points:
  alpha, TorBrowserTeam201910                    |
Parent ID:  #10760                               |         Points:  0.5
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor9
-------------------------------------------------+-------------------------
Changes (by gk):

 * keywords:  ux-team, tbb-newnym, tbb-9.0-must-alpha, TorBrowserTeam201910R
     => ux-team, tbb-newnym, tbb-9.0-must-alpha, TorBrowserTeam201910
 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:23 acat]:
 > Patches for review: https://github.com/acatarineu/tor-
 browser/commit/27511 and
 https://github.com/acatarineu/torbutton/commit/27511.
 >
 > I moved some code and resources from torbutton to tor-browser, I hope I
 did not miss anything.
 >
 > Although it was not part of the plan, I also added `New Tor Circuit for
 this site` to customizable UI, but not visible by default. Just in case
 someone wants to have that button somewhere. I think we don't lose
 anything :)

 Good idea. Could you mention that in your commit message as well?

 The Torbutton changes look good to me. For the `tor-browser` ones I have
 some nits:

 1) Please change
 {{{
 +    if (currentTorVersion < 1) {
 }}}
 to
 {{{
 +    if (currentTorVersion < 1 && gSavedState.placements) {
 }}}
 to follow the pattern in the code block (and checking for `placements` is
 good in itself).

 2) We have a shortcut for the New Identity button. Could you add that one
 to the tooltip, too? It's done for the reload button in Firefox and seems
 to be a good idea.

 Otherwise we are good.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27511#comment:25>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online