[tbb-bugs] #32342 [Applications/Tor Browser]: Tor Browser for Android crashes when opening the locale pane in the settings

[Tor Bug Tracker & Wiki]

#32342: Tor Browser for Android crashes when opening the locale pane in the
settings
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:  new
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Major                                |     Resolution:
 Keywords:  tbb-mobile, tbb-crash,               |  Actual Points:
  tbb-9.0-issues, tbb-regression,                |
  tbb-9.0.1-can, TorBrowserTeam201910            |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by sysrqb):

 More information. These two apks are built using the same code (same tor
 browser tags), except the first apk was not decompiled/recompiled with
 apktools, and the second one was decompiled/recompiled.

 {{{
 $ unzip -vl tor-browser-tbb-nightly-android-x86_64-multi-qa.apk | grep -c
 Stored
 992
 $ unzip -vl tor-browser-tbb-nightly-android-x86_64-multi-qa.apk | grep -c
 Defl:N
 17
 $ unzip -vl tor-browser-tbb-nightly-android-x86_64-multi-qa.apk | grep -c
 Defl:X
 601
 $ unzip -vl tor-browser-tbb-nightly-android-x86_64-multi-qa-apktools.apk |
 grep -c Stored
 50
 $ unzip -vl tor-browser-tbb-nightly-android-x86_64-multi-qa-apktools.apk |
 grep -c Defl:N
 1523
 $ unzip -vl tor-browser-tbb-nightly-android-x86_64-multi-qa-apktools.apk |
 grep -c Defl:X
 0
 }}}

 Interestingly, the apk after undergoing the apktools operations has nearly
 40 fewer files than the original:
 {{{
 $ unzip -vl tor-browser-tbb-nightly-android-x86_64-multi-qa.apk | tail
  1884528  Defl:N   912273  52% 2000-01-01 00:00 ce735645
 lib/x86_64/libnss3.so
   450840  Defl:N   181385  60% 2000-01-01 00:00 aa82c9ac
 lib/x86_64/libnssckbi.so
     6144  Defl:N     1699  72% 2000-01-01 00:00 3fcc6519  lib/x86_64
 /libplugin-container.so
   248776  Defl:N   103213  59% 2000-01-01 00:00 7c9b3218
 lib/x86_64/libsoftokn3.so
 86677040  Defl:N 32647854  62% 2000-01-01 00:00 72313002
 lib/x86_64/libxul.so
   185868  Defl:N    67119  64% 2010-01-01 00:00 e03d0b4b  META-
 INF/ANDROIDQ.SF
     1202  Defl:N     1061  12% 2010-01-01 00:00 c37c148a  META-
 INF/ANDROIDQ.RSA
   185806  Defl:N    65400  65% 2010-01-01 00:00 1f308f3c  META-
 INF/MANIFEST.MF
 --------          -------  ---                            -------
 140875793         62633420  56%                            1610 files

 $ unzip -vl tor-browser-tbb-nightly-android-x86_64-multi-qa-apktools.apk |
 tail
      548  Defl:N      306  44% 2000-01-01 00:00 f4fe1304
 res/xml/search_widget_info.xml
      528  Defl:N      309  42% 2000-01-01 00:00 61084447
 res/xml/searchable.xml
      480  Defl:N      273  43% 2000-01-01 00:00 a65db3b7
 res/xml/separator.xml
   989460  Defl:N   182780  82% 2000-01-01 00:00 0a521646  resources.arsc
       10  Defl:N        9  10% 2000-01-01 00:00 74f0468e  ua-update.json
   178021  Defl:N    65101  63% 2000-01-01 00:00 4544c219  META-
 INF/ANDROIDQ.SF
     1202  Defl:N     1060  12% 2000-01-01 00:00 d3bd34b2  META-
 INF/ANDROIDQ.RSA
   177897  Defl:N    64294  64% 2000-01-01 00:00 1ba5281c  META-
 INF/MANIFEST.MF
 --------          -------  ---                            -------
 141003330         61214222  57%                            1573 files
 }}}

 I don't know the tradeoffs of Defl:N vs. Defl:X. At this point I'll write
 a patch for the "terrible hack" I mentioned earlier (explicitly force zip
 "storing" omni.ja), unless someone else has a better idea.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32342#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online