[tbb-bugs] #30573 [Applications/Tor Browser]: TBA: open with Tor Browser does not work if Tor Browser is not open already
Tor Bug Tracker & Wiki
blackhole at torproject.org
Fri May 31 14:38:18 UTC 2019
#30573: TBA: open with Tor Browser does not work if Tor Browser is not open already
-----------------------------------------------+---------------------------
Reporter: emmapeel | Owner: tbb-team
Type: defect | Status:
| needs_review
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: tbb-mobile, TorBrowserTeam201905R | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
-----------------------------------------------+---------------------------
Changes (by sysrqb):
* keywords: tbb-mobile => tbb-mobile, TorBrowserTeam201905R
* status: new => needs_review
Comment:
I have a branch ready for review in my repo, `bug30573_8.5_01`. This
simply delays loading the requested page until after all tabs are
"sanitized" (closed) and tor finishes bootstrapping. I have another branch
for the alpha, I'll post that soon.
This branch creates an event dispatch listener for events
`Sanitize:Finished` and `Tor:Ready`. It begins by checking the current
status (if sanitizing tabs is enabled and if tor is not started). These
values are used for initializing the event listener. The listener listens
for a "fake" event (`Tor:CheckIfReady`) as well, which is emitted
immediately after creation, in case tor is running already and tabs won't
be sanitized.
After the necessary events are received, then the tab is loaded. This
prevents both the tab loading before all tabs are closed during the
sanitization (therefore closing this new tab, as well), and this prevents
loading the tab before tor is ready and showing a proxy network error page
while the tab is reloading (which we force after tor bootstrap completes).
Overall, this seems like a better experience.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30573#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tbb-bugs
mailing list