[tbb-bugs] #28119 [Applications/Tor Browser]: Provide Tor Browser for Android for arm64-v8a devices

Tor Bug Tracker & Wiki blackhole at torproject.org
Wed May 29 19:29:15 UTC 2019

#28119: Provide Tor Browser for Android for arm64-v8a devices
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-rbm, tbb-mobile,                 |  Actual Points:
  TorBrowserTeam201905, GeorgKoppen201905        |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
Changes (by boklm):

 * keywords:  tbb-rbm, tbb-mobile, TorBrowserTeam201905R, GeorgKoppen201905
     => tbb-rbm, tbb-mobile, TorBrowserTeam201905, GeorgKoppen201905
 * status:  needs_review => needs_revision


 Replying to [comment:7 gk]:
 > Okay, I got another reminder from Google about Tor Browser being in need
 for an arm64 version, so I dusted my old patch off. `bug_28119_v4`
 has the patch for review.

 I see we set a different value for `var/android_min_api` for aarch64 and
 the other architectures. However, in `projects/android-toolchain/build`,
 we create one toolchain tarball containing all architectures, and we use
 `var/android_min_api` for all of them. However `var/android_min_api` only
 contains the value corresponding to the architecture we are currently
 building. So I think we should not use `var/android_min_api` in `projects
 /android-toolchain/build`, and instead do something like this:
 ./build/tools/make_standalone_toolchain.py --api 16 --arch arm --install-
 ./build/tools/make_standalone_toolchain.py --api 16 --arch x86 --install-
 ./build/tools/make_standalone_toolchain.py --api 21 --arch aarch64

 Or to avoid duplicating the api version in two places:
 diff --git a/projects/android-toolchain/build b/projects/android-
 index 588aab9..e0f59a9 100644
 --- a/projects/android-toolchain/build
 +++ b/projects/android-toolchain/build
 @@ -18,11 +18,9 @@ cd $NDK_HOME
  mv android-ndk-r15c/* .
  rm -fR android-ndk-r15c

 -# The architectures we support
 -archs="arm x86 arm64"
 -for arch in $archs; do
 -  ./build/tools/make_standalone_toolchain.py --api [%
 c("var/android_min_api") %] --arch $arch --install-dir=./$arch
 +./build/tools/make_standalone_toolchain.py --api [%
 c("var/android_min_api_armv7") %] --arch arm --install-dir=./arm
 +./build/tools/make_standalone_toolchain.py --api [%
 c("var/android_min_api_x86") %] --arch x86 --install-dir=./x86
 +./build/tools/make_standalone_toolchain.py --api [%
 c("var/android_min_api_aarch64") %] --arch arm64 --install-dir=./arm64

  # Tool Archives
  cd $SDK_HOME
 diff --git a/rbm.conf b/rbm.conf
 index c344e6f..fe3f406 100644
 --- a/rbm.conf
 +++ b/rbm.conf
 @@ -196,15 +196,17 @@ targets:
      arch: aarch64
        android-aarch64: 1
 -      # API 21 is the minimum we currently support for arm64 on Android
 -      android_min_api: 21
        osname: android-aarch64
        android: 1
        compiler: android-toolchain
        # API 16 is the minimum we currently support for Tor Browser on
 -      android_min_api: 16
 +      android_min_api: '[% SET arch = c("var/arch"); GET
 c("var/android_min_api_" _ arch) %]'
 +      # API 21 is the minimum we currently support for arm64 on Android
 +      android_min_api_aarch64: 21
 +      android_min_api_armv7: 16
 +      android_min_api_x86: 16
        snowflake: 0
          suite: stretch

Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28119#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

More information about the tbb-bugs mailing list