[tbb-bugs] #26844 [Applications/Tor Browser]: TBA: Investigate/Setup Fastlane

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon May 27 14:19:41 UTC 2019

#26844: TBA: Investigate/Setup Fastlane
 Reporter:  sysrqb                               |          Owner:  tbb-
                                                 |  team
     Type:  task                                 |         Status:
                                                 |  needs_revision
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-mobile, tbb-8.5,                 |  Actual Points:
  TorBrowserTeam201905                           |
Parent ID:  #26782                               |         Points:
 Reviewer:                                       |        Sponsor:
Changes (by gk):

 * status:  needs_review => needs_revision
 * keywords:  tbb-mobile, tbb-8.5, TorBrowserTeam201905R => tbb-mobile,
     tbb-8.5, TorBrowserTeam201905


 Replying to [comment:17 sysrqb]:
 > Replying to [comment:14 gk]:


 > > 2) `2015539345.txt`
 > >
 > > s/Tor Browser for Android/Tor Browser/g
 > >
 > These are old changelogs (the changelogs we originally published with
 the releases). I don't think we should (basically) change history at this

 Right, sounds good.

 > > 3) Why do we have the Changelog for 8.5a9 and 8.5a10 twice (and we
 should add the Changelog for 8.5a11)
 > > basically
 > There is one changelog per apk per release - so one for armv7 and
 another for x86. I only created one for the entire release, but it seems
 Google used that changelog and automatically created one for each apk.

 I see. That's a bit sad. But on the other hand that is probably okay in
 case we need to have per-arch differences. I just wished the
 Changlogs/file names would indicate the architecture somehow to make it
 less confusing.

 > > 4) `full_description.txt`
 > >
 > > There are some trailing whitespaces that are superfluous
 > >
 > > s/Tor Browser for Android/Tor Browser/
 > >
 > > I think the "Known issue:" is fixed as well as the note that we need
 > >
 > Done.

 Looks good. While re-reading the text is it still correct to say: "Give
 today, and Mozilla will match your gift"? I thought that was just for the
 year-end campaign? (I mean I'd would be cool if that were still true,


 > >
 > > 7) `TBA Welcome Page at 3x.png`
 > >
 > > Should we update that and the @1 and @2 versions to contain the
 newsletter signup line as well which we have since #29035?
 > I created #29834 for this. I think we can update them later.

 Works for me.


 > > 9) General
 > >
 > > That's for the alpha releases right now. We should probably integrate
 the respective icon and text for the stable one as well given that we want
 to have different series. Not sure how that works, though.
 > Yes, I see two options here. The first option is we follow tor-browser-
 build and create one branch per series (`master`, `maint-8.5`, `nightly`
 (?)). The second option is only using the master branch and creating a
 different `fastlane/` directory for each series, e.g. `fastlane_stable/`,
 `fastlane_alpha/`, `fastlane_nightly/`. Actually, if we use the second
 option, then we can create a common directory as `fastlane/` or
 `fastlane_shared/` where all of the shared files are stored (like the
 descriptions) and then we can create symlinks from both
 `image_repository/` and `fastlane/` in each series, as needed, for all
 shared resources.

 Yes, please. The second option sounds pretty good to me.

 > I can begin this in the next patch.

 Okay. Setting to `needs_revision` again.

Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26844#comment:20>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

More information about the tbb-bugs mailing list