[tbb-bugs] #30501 [Applications/Tor Browser]: BridgesList Preferences is an overloaded field

[Tor Bug Tracker & Wiki]

#30501: BridgesList Preferences is an overloaded field
-------------------------------------+-------------------------------------
     Reporter:  sisbell              |      Owner:  tbb-team
         Type:  defect               |     Status:  new
     Priority:  Medium               |  Milestone:
    Component:  Applications/Tor     |    Version:
  Browser                            |   Keywords:  tbb-mobile,
     Severity:  Normal               |  tbb-8.5-must, TorBrowserTeam201905
Actual Points:                       |  Parent ID:
       Points:                       |   Reviewer:
      Sponsor:                       |
-------------------------------------+-------------------------------------
 BridgesList is an overloaded field, which can cause some confusion. The
 list can be:

  1. a filter like obfs4 or meek OR
  1. can be a custom bridge

 For (1), we just pass back all bridges, the filter will occur elsewhere in
 the library. For (2) we return the bridge list as a raw stream. If length
 is greater than 5, then we know this is a custom bridge

 We should fix this so that we have separate preferences for 1 and 2. We
 also shouldn't be looking at string length to determine field type.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30501>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online