[tbb-bugs] #28044 [Applications/Tor Launcher]: Integrate Tor Launcher into tor-browser

Tor Bug Tracker & Wiki blackhole at torproject.org
Thu May 9 11:38:53 UTC 2019

#28044: Integrate Tor Launcher into tor-browser
 Reporter:  gk                                   |          Owner:  brade
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Launcher            |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  AffectsTails, ux-team,               |  Actual Points:
  TorBrowserTeam201905                           |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
Changes (by gk):

 * status:  needs_review => needs_revision
 * keywords:  AffectsTails, ux-team, TorBrowserTeam201905R => AffectsTails,
     ux-team, TorBrowserTeam201905


 Replying to [comment:13 mcs]:

 Okay, 9.0a1 is on the horizon.

 > This work is now ready for review. There are 3 Tor Launcher commits
 which are available on the `bug28044-01` branch within the brade repo:
 > https://gitweb.torproject.org/user/brade/tor-

 b7e7058359b402e9f37e27a86b99b68702189cdb - looks good
 80cedf677bb43d10c6b37902ca22af7650752bf0 just one white space between
 "locale" and "torlauncher" (in `+% locale   torlauncher en-US %locale/en-
 US/`) as used for the other locales and no "/" at the end of `locale/en-
 US/` as done with the other locales, otherwise this looks good
 2dd09cb68db2b267cd12db7ce542406791fd6ef7 - there are some conflicts with
 the languages strings (sorry for that), otherwise this looks good

 > There is one tor-browser commit:
 > https://gitweb.torproject.org/user/brade/tor-

 Looks good to me.

 > And one tor-browser-build commit:
 > https://gitweb.torproject.org/user/brade/tor-browser-

 Looks good to me.

 > We also need to update the proposal to account for feedback we received
 from Tails as well as a couple of other things we learned; we will do that

 Okay, works for me in a follow-up ticket.

 > For localization, including all of the completed translations seems to
 work fine. Also, we ended up keeping the `pkg-prepare` target in the Tor
 Launcher Makefile because it may be useful for TorBirdy or other projects
 (that Makefile is no longer used by the tor-browser-build process).

 Sounds good.

Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28044#comment:20>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

More information about the tbb-bugs mailing list