[tbb-bugs] #10760 [Applications/Tor Browser]: Integrate TorButton to TorBrowser core to prevent users from disabling it

Tor Bug Tracker & Wiki blackhole at torproject.org
Wed May 8 15:08:32 UTC 2019

#10760: Integrate TorButton to TorBrowser core to prevent users from disabling it
 Reporter:  Rezonansowy                          |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:  new
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  AffectsTails, tbb-parity,            |  Actual Points:
  TorBrowserTeam201904, GeorgKoppen201904        |
Parent ID:  #24855                               |         Points:
 Reviewer:                                       |        Sponsor:

Comment (by mcs):

 Replying to [comment:30 gk]:
 > I think the reason Tor Launcher is in the `browser` dir is that we don't
 have a Tor Launcher on Android (and won't have one), thus it is desktop-
 specific. While that's not the case for Torbutton (even though we don't
 use the tor-browser version for desktop yet).

 I don't remember all of the reasons, but one reason we put the Tor
 Launcher code under browser/extensions is because we were following the
 example of other built-in "extensions" such as pdfjs.

 > > There is this `GetOverrideStringBundle` function in
 that would need to be fixed, since the XPI would not be there. But I
 wonder if this code is still needed since `general.useragent.locale` pref
 is not there anymore (was moved to `intl.locale.requested`).
 > Good question and I don't know the answer to it right now...

 I think it is a bug that that code still uses `general.useragent.locale`.
 When we integrate Torbutton or its code into the tor-browser repo, we need
 to decide what to do for localization. The code in nsAppRunner.cpp can
 probably be simplified if we can assume that Torbutton's locale files are
 always present.

Ticket URL: <https://trac.torproject.org/projects/tor/ticket/10760#comment:31>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

More information about the tbb-bugs mailing list