[tbb-bugs] #30375 [Applications/Tor Browser]: Backported fix for bug 24622 does not compile with --enable-tests

Tor Bug Tracker & Wiki blackhole at torproject.org
Fri May 3 12:47:11 UTC 2019

#30375: Backported fix for bug 24622 does not compile with --enable-tests
 Reporter:  gk                        |          Owner:  tbb-team
     Type:  defect                    |         Status:  closed
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:  fixed
 Keywords:  TorBrowserTeam201905      |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:
Changes (by gk):

 * status:  new => closed
 * resolution:   => fixed


 Replying to [comment:1 acat]:
 > I forgot to add the headers: https://github.com/acatarineu/tor-

 Thanks, looks good to me (in fact I should have caught this when applying
 your mozilla-central patch to esr60... :/ ).

 I modified your commit message a bit. Could you use a fixup commit next
 time? You could mention the bug it closes in it to have some reference.
 But that way we could squash the commits during the next rebase which
 would make it easier to keep track of the patches. Anyway, cherry-picked
 to `tor-browser-60.6.1esr-8.5-1` (commit

 (And, please set the ticket state to `needs_review` and ideally adding the
 `TorBrowserTeamYYYMMR` keyword so that the ticket does not fall through
 the cracks).

Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30375#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

More information about the tbb-bugs mailing list