[tbb-bugs] #27503 [Applications/Tor Browser]: Disabling accessibility on Windows breaks screen readers

[Tor Bug Tracker & Wiki]

#27503: Disabling accessibility on Windows breaks screen readers
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:
                                                 |  pospeselr
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-8.0-issues, tbb-regression,      |  Actual Points:
  GeorgKoppen201903, TorBrowserTeam201906R,      |
  tbb-8.5                                        |
Parent ID:                                       |         Points:
 Reviewer:  boklm                                |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by pospeselr):

 Ok so the crash we're seeing on 64-bit windows is an exception raised by
 combase.dll!ObjectStublessClient. Essentially that method bails out if
 it's found the stub was built with midl.exe older than version 5.2.202, so
 the fix is to just update the version constant inserted by widl. I've
 tested on 64-bit windows with NVDA and Tor Browser now transitions from
 the network dialog to the main browser window without crashing.

 wine (for wine-devel review):
 https://github.com/pospeselr/wine/commits/winedev
 wine (with mingw include patch):
 https://github.com/pospeselr/wine/commits/bug_27503

 tor-browser-build (ammended with updated widl patch):
 https://gitweb.torproject.org/user/richard/tor-browser-
 build.git/commit/?h=bug_27503

 Test builds:
 i686: soon
 amd64: https://people.torproject.org/~richard/builds/torbrowser-install-
 tbb-nightly_en-US-amd64-27503-candidate3.exe

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27503#comment:82>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online