[tbb-bugs] #30334 [Applications/Tor Browser]: build_go_lib for executables?

[Tor Bug Tracker & Wiki]

#30334: build_go_lib for executables?
-------------------------------------------+-------------------------------
 Reporter:  JeremyRand                     |          Owner:  tbb-team
     Type:  enhancement                    |         Status:
                                           |  needs_revision
 Priority:  Medium                         |      Milestone:
Component:  Applications/Tor Browser       |        Version:
 Severity:  Normal                         |     Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201906  |  Actual Points:
Parent ID:                                 |         Points:
 Reviewer:                                 |        Sponsor:
-------------------------------------------+-------------------------------
Changes (by boklm):

 * keywords:  tbb-rbm, TorBrowserTeam201906R => tbb-rbm,
               TorBrowserTeam201906
 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:3 JeremyRand]:
 > Patch at https://notabug.org/JeremyRand/tor-browser-build/src/build-go-
 lib-exe (commit hash 690a8334a7c7c3e7db40f09783da7096d5ab4c56).  There was
 indeed a lot of boilerplate / duplicated code present in
 meek/obfs4/snowflake, and I think this patch does a reasonably good job of
 improving the situation.  I definitely find the code easier to read with
 this patch applied, though admittedly this is subjective and I'm probably
 biased toward finding code that I wrote easy to read.

 I think this looks mostly good.

 A possible improvement is to add a `var/build_go_lib_post` option, move
 the instructions to generate the archives there, and then remove the
 `build` files. This will avoid having part of the custom instructions in
 `config` and an other part in `build`.

 An other minor thing is the missing indentation after the `IF
 !c("var/go_lib_no_output")`.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30334#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online