[tbb-bugs] #30321 [Applications/Tor Browser]: Adapt Linux toolchain for Firefox 68 ESR

[Tor Bug Tracker & Wiki]

#30321: Adapt Linux toolchain for Firefox 68 ESR
--------------------------------------+--------------------------
 Reporter:  gk                        |          Owner:  tbb-team
     Type:  task                      |         Status:  new
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  tbb-rbm, ff68-esr         |  Actual Points:
Parent ID:  #30320                    |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+--------------------------

Comment (by gk):

 Replying to [comment:6 gk]:
 > https://github.com/rust-lang/rust/issues/61468
 > https://bugs.gentoo.org/687028
 >
 > seem to be relevant as well.

 Alright, some follow-ups: I tried a bunch of random things to no avail
 (using precompiled Rust versions 1.34.1, 1.35.0, just compiling Firefox
 with `-j1`, trying to make sure `cargo` is compiling only with `-j1`,
 resuming the build from within the VM, which surprisingly worked) and
 ended up with omitting `--verbose` to our `mach build` incantation which
 "worked". Trying to figure out the underlying problem Alex Crichton
 pointed me on the right path by linking to https://github.com/travis-ci
 /travis-ci/issues/4704. In particular https://github.com/travis-ci/travis-
 ci/issues/4704#issuecomment-348435959 has been useful:
 {{{
 Pretty much every commandline tool expects stdout to be in blocking mode,
 and does not properly retry when in nonblocking mode.
 }}}
 Testing the Python snippets from that bug both on the host machine and in
 the VM did not show any issues, thus something must change the blocking
 mode during compilation.

 And, indeed, after more digging I stumbled over

 https://github.com/nodejs/node/issues/14752
 https://github.com/bnoordhuis/io.js/commit/256614ad5335419b75c798bf0d136bf1a0395e81

 and I could reproduce the issue with the Python snippets from the Travis
 bug report and work around it.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30321#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online