[tbb-bugs] #30845 [Applications/Tor Browser]: Make sure default Firefox themes are enabled on ESR68

[Tor Bug Tracker & Wiki]

#30845: Make sure default Firefox themes are enabled on ESR68
------------------------------------------+----------------------
     Reporter:  acat                      |      Owner:  tbb-team
         Type:  defect                    |     Status:  new
     Priority:  Medium                    |  Milestone:
    Component:  Applications/Tor Browser  |    Version:
     Severity:  Normal                    |   Keywords:  ff68-esr
Actual Points:                            |  Parent ID:
       Points:                            |   Reviewer:
      Sponsor:                            |
------------------------------------------+----------------------
 With current `000-tor-browser.js` prefs default theme extensions are not
 installed. `AddonManager.maybeInstallBuiltinAddon` is used to install
 these, which requires enabledScopes to have flag 4 (application scope). So
 changing `extensions.enabledScopes` from 1 to 5 fixes this.

 My understanding is that this should only allow installing extensions from
 application directory, which we control. Is there any reason not to do
 this change?

 Also, some related prefs seem obsolete:

 {{{
 extensions.bootstrappedAddons
 extensions.enabledAddons
 extensions.enabledItems
 }}}

 We could also use this to clean them up.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30845>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online