[tbb-bugs] #29670 [Core Tor/Tor]: Could not create SOCKS args string

[Tor Bug Tracker & Wiki]

#29670: Could not create SOCKS args string
-------------------------------------------------+-------------------------
 Reporter:  cypherpunks                          |          Owner:  nickm
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.1.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  035-backport, 040-backport, ux,      |  Actual Points:  .2
  regression?, 041-should,                       |
Parent ID:                                       |         Points:  .5
 Reviewer:  catalyst                             |        Sponsor:
                                                 |  Sponsor19
-------------------------------------------------+-------------------------
Changes (by catalyst):

 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:21 nickm]:
 > I have a possible fix in a branch called `bug29670_035` with a PR in
 https://github.com/torproject/tor/pull/1056
 >
 > I have run a couple of experiments with it, but I do not have the right
 kind of local socks proxy to try this out.  If somebody else could see
 whether it fixes the bug, that would help greatly.
 Thanks! Look reasonable by visual inspection. The practracker exceptions
 need updating though, which is why the tests seem to be failing.

 I'm going to try to manually test it on Tor Browser.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29670#comment:26>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online