[tbb-bugs] #29185 [Applications/Tor Browser]: 8.5a7-build3 Windows .exe files are not reproducibly built

[Tor Bug Tracker & Wiki]

#29185: 8.5a7-build3 Windows .exe files are not reproducibly built
--------------------------------------+--------------------------
 Reporter:  gk                        |          Owner:  tbb-team
     Type:  defect                    |         Status:  new
 Priority:  Immediate                 |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  TorBrowserTeam201901      |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+--------------------------

Comment (by langpack):

 Replying to [comment:6 gk]:
 > Replying to [comment:5 langpack]:
 > > Replying to [comment:3 gk]:
 > > > Replying to [comment:2 langpack]:
 > > > > {{{
 > > > > - makensis -DCHANNEL=[% c("var/channel") %] torbrowser.nsi
 > > > > + makensis /DCHANNEL=[% c("var/channel") %] torbrowser.nsi
 > > > > }}}
 > > >
 > > > That just breaks the build with `Can't open script
 "/DCHANNEL=alpha"`.
 > > Oh, it seems https://sourceforge.net/p/nsis/bugs/568/ doesn't work,
 because this is a some kind of cross-nsis like
 https://github.com/inponomarev/nsis/blob/master/tasks/main.yml
 > > But, please, use the latest security update (3.04) with fixed
 https://sourceforge.net/p/nsis/bugs/1204/
 >
 > Yes, we should do that and we have #29187 for that. However, switching
 to it does not solve this bug.
 Will #29187 be included in 8.5a7? Should it?
 As a quick possible solution:
 {{{
 - makensis -DCHANNEL=[% c("var/channel") %] torbrowser.nsi
 + makensis -DCHANNEL="[% c("var/channel") %]" torbrowser.nsi
 }}}
 ?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29185#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online