[tbb-bugs] #29182 [Applications/Tor Browser]: Release candidate build breaks on Android with "error: hidden symbol 'arc4random_buf' is not defined locally"

[Tor Bug Tracker & Wiki]

#29182: Release candidate build breaks on Android with  "error: hidden symbol
'arc4random_buf' is not defined locally"
--------------------------------------+--------------------------
 Reporter:  gk                        |          Owner:  tbb-team
     Type:  defect                    |         Status:  new
 Priority:  Immediate                 |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  TorBrowserTeam20901       |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+--------------------------

Comment (by sysrqb):

 Quick update. I'm testing with this nowish (seems somewhat promising):

 {{{
 diff --git a/parser/expat/lib/xmlparse.c b/parser/expat/lib/xmlparse.c
 index 209f20e094dc..056974e1479d 100644
 --- a/parser/expat/lib/xmlparse.c
 +++ b/parser/expat/lib/xmlparse.c
 @@ -839,7 +839,7 @@ generate_hash_secret_salt(XML_Parser parser)
  {
    unsigned long entropy;
    (void)parser;
 -#if defined(HAVE_ARC4RANDOM_BUF) || defined(__CloudABI__)
 +#if (defined(HAVE_ARC4RANDOM_BUF) || defined(__CloudABI__)) &&
 !defined(ANDROID)
    (void)gather_time_entropy;
    arc4random_buf(&entropy, sizeof(entropy));
    return ENTROPY_DEBUG("arc4random_buf", entropy);
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29182#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online