[tbb-bugs] #28885 [Applications/Tor Browser]: notify users that update is downloading

Tor Bug Tracker & Wiki blackhole at torproject.org
Thu Jan 24 20:22:19 UTC 2019


#28885: notify users that update is downloading
-------------------------------------------+-------------------------------
 Reporter:  mcs                            |          Owner:  tbb-team
     Type:  defect                         |         Status:
                                           |  needs_revision
 Priority:  Medium                         |      Milestone:
Component:  Applications/Tor Browser       |        Version:
 Severity:  Normal                         |     Resolution:
 Keywords:  TorBrowserTeam201901, ux-team  |  Actual Points:
Parent ID:  #25694                         |         Points:
 Reviewer:                                 |        Sponsor:
-------------------------------------------+-------------------------------

Comment (by gk):

 Replying to [comment:5 mcs]:
 > Replying to [comment:3 gk]:
 > > Here is what I got so far:
 > >
 > > 1) I wonder whether we should use a different icon for the download
 (like an arrow *down*) as we have
 > > the arrow up associaed with *up*date is ready to get applied and this
 is the general Firefox meaning of that icon. I am a bit worried that we
 set user expectations wrong here one can't discriminate between the
 download and ready-to-apply state at a glance.
 >
 > We opted to use the same icon because Mozilla uses the same upward arrow
 icon for all updater-related messages, i.e.,
 > {{{
 >   Download Tor Browser update            // Shown if automatic updates
 are disabled
 >   Download a fresh copy of Tor Browser   // shown if the update fails
 >   Restart to update Tor Browser
 > }}}
 >
 > Kathy and I don't have strong feelings about using one icon or two,
 although we have not looked at how difficult it would be to use more than
 one. In some of explorations Antonela did in #25694, the design did
 include a different icon for restart as well. Kathy and I would like to
 minimize changes we make so as to avoid diverging from Firefox too much.

 Okay. Not needed for this bug anyway, just something I was wondering while
 testing.

 > > 2) If one has the about dialog open while a download is happening,
 closes it, opens the hamburger menu and clicks on menuitem then the
 download stops. I guess this is unexpected and should get fixed?
 > > (Interestingly enough, after clicking the about dialog in that
 scenario and opening it again shows 0 of XX MB at the beginning. It jumps
 to the already download amount (and goes from there) later on when the
 download is resumed. It seems showing "0" in this case is wrong.)
 >
 > Kathy and I will try to reproduce this bug. Does clicking the
 "Downloading..." menu item open the about dialog like it is supposed to
 (at which point the download stops)? By "stops" do you mean "stops making
 progress" or do you mean the download is completely canceled?

 Yes, it opens the dialog. It's not canceled in the way that one has to
 start over again but it suddenly stops making progress (and the icon on
 the hamburger menu + the menuitem vanish).

 > Showing 0MB when resuming a download is probably not something we
 introduced but we could look into it. When the about dialog or large
 update dialog is opened (i.e., via "Check for Tor Browser update"),
 Mozilla stops and restarts the download. This may be the root cause of
 some of the problems you saw. They used to download MAR files slowly when
 no UI was visible, which is the origin of the stop and restart behavior. I
 am not sure if we can easily eliminate that code though.

 Okay, thanks for the explanation. It's been confusing that trying to get
 more information about the download progress by clicking on that item
 suddenly stops this progress. And it is not resuming automatically once
 the dialog closes or something. One has to re-trigger the update process
 to get it going again.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28885#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tbb-bugs mailing list