[tbb-bugs] #26858 [Applications/Tor Browser]: TBA: Investigating patching AccountManager

[Tor Bug Tracker & Wiki]

#26858: TBA: Investigating patching AccountManager
-------------------------------------------------+-------------------------
 Reporter:  sysrqb                               |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-mobile, TBA-a3,                  |  Actual Points:
  TorBrowserTeam201901                           |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor8
-------------------------------------------------+-------------------------
Changes (by gk):

 * keywords:  tbb-mobile, TBA-a3, TorBrowserTeam201901R => tbb-mobile,
     TBA-a3, TorBrowserTeam201901
 * status:  needs_review => needs_revision


Comment:

 Sorry, for the long delay here. I started looking into the patches today.
 It seems they do not compile (anymore) I checked with my bug_26858_test
 branch and get:
 {{{
  0:31.73
 :app:compileOfficialWithoutGeckoBinariesNoMinApiPhotonDebugJavaWithJavac/var/tmp/build
 /firefox-
 cbe1939d23ce/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java:153:
 error: cannot find symbol
  0:31.73 import org.mozilla.gecko.telemetry.TelemetryCorePingDelegate;
  0:31.73                                   ^
  0:31.73   symbol:   class TelemetryCorePingDelegate
  0:31.73   location: package org.mozilla.gecko.telemetry
  0:31.77 /var/tmp/build/firefox-
 cbe1939d23ce/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java:427:
 error: cannot find symbol
  0:31.77     private final TelemetryCorePingDelegate
 mTelemetryCorePingDelegate = new TelemetryCorePingDelegate();
  0:31.78                   ^
  0:31.78   symbol:   class TelemetryCorePingDelegate
  0:31.78   location: class BrowserApp
  0:32.17 /var/tmp/build/firefox-
 cbe1939d23ce/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java:427:
 error: cannot find symbol
  0:32.17     private final TelemetryCorePingDelegate
 mTelemetryCorePingDelegate = new TelemetryCorePingDelegate();
  0:32.17
 ^
  0:32.17   symbol:   class TelemetryCorePingDelegate
  0:32.17   location: class BrowserApp
  0:33.23 Note: Some input files use or override a deprecated API.
  0:33.23 Note: Recompile with -Xlint:deprecation for details.
  0:33.23 3 errors
  0:33.25  FAILED
 }}}

 Additionally, do we actually need the `TabSender` interface in our
 `SendTab` stub?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26858#comment:17>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online