[tbb-bugs] #29080 [Applications/Tor Browser]: Merge OrbotService and TOPL

[Tor Bug Tracker & Wiki]

#29080: Merge OrbotService and TOPL
-------------------------------------------------+-------------------------
 Reporter:  sisbell                              |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:  new
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-mobile, TBA-a3,                  |  Actual Points:
  TorBrowserTeam201901                           |
Parent ID:  #27609                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by sisbell):

 I've made the following changes to TOPL

  * Add custom torrc location through OnionProxyContext
  * Added an EventBroadcaster. Orbot will pass in an implementation so that
 TOPL broadcasts the same events as Orbot currently broadcasts.
  * Added the following methods to OnionProxyManager: killTorProcess,
 reloadTorConfig, getTorPid, newIdentity, disableNetwork, setExitNodes
  * Added resolvConf to TorConfig class
  * Added a new TorConfigBuilder class which included parsing and loading
 of bridges from file

 These changes make TOPL support the base features that Orbot needs.

 Changes to Orbot:

  * Moved over functionality to TOPL as part of integration (see above)
  * Use TOPL for tor installation and bootstrapping.
  * Created EventBroadcaster implementation (previously from code in
 TorService)
  * Rewrite DBs (in progress)

 TorService was 2K file, now its below 500 lines so a lot more manageable.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29080#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online