[tbb-bugs] #31449 [Applications/Tor Browser]: Signing tools for 32bit Linux are 64bit now

[Tor Bug Tracker & Wiki]

#31449: Signing tools for 32bit Linux are 64bit now
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:  new
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201908,       |  Actual Points:
  tbb-9.0-must-alpha                             |
Parent ID:  #30321                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):

 * status:  needs_information => new


Comment:

 Replying to [comment:3 boklm]:
 > After looking at this issue, it seems that:
 > - `signmar` is the same as `mar` with some additional features. So if we
 need a 32 bit `mar`, we could probably use `signmar`.

 If we could verify that and/or be sure that `signmar` is not calling `mar`
 under the hood that would be good.

 > - we can use this patch to build `mbsdiff` for linux32:
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/tree/projects/firefox/mbsdiff.patch?h=bug_31449_v3
 >
 > However it seems that the only place where `mbsdiff` is used is for
 generating incremental mar files, which we usually do on a 64bit machine,
 so I'm not sure we need a 32bit `mbsdiff`. It seems also that our signing
 script is only using `signmar` and not `mar`. Is there an other reason
 that I'm forgetting for wanting 32bit versions of `mbsdiff` and `mar`?

 Fair enough. I was under the impression that the current state risks our
 `mar` signing AND that we do something wrong with our 32bit builds given
 that the issue did not happen in the past and we already seem to need some
 hacks to get 32bit builds going. If neither is the case, great! We could
 closed this ticket then as WORKSFORME or something similar.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31449#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online