[tbb-bugs] #28329 [Applications/Tor Browser]: Design TBA+Orbot configuration UI/UX

[Tor Bug Tracker & Wiki]

#28329: Design TBA+Orbot configuration UI/UX
-------------------------------------------------+-------------------------
 Reporter:  sysrqb                               |          Owner:  tbb-
                                                 |  team
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-mobile, ux-team, TBA-a3,         |  Actual Points:
  tbb-8.5-must-alpha, TorBrowserTeam201904       |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor8
-------------------------------------------------+-------------------------

Comment (by gk):

 Replying to [comment:91 sysrqb]:
 > Replying to [comment:88 gk]:

 [snip]

 > >
 > > {{{
 > >         final int expectedHeight = (int)
 (currentWidth*imgHeight/imgWidth);
 > >         final int expectedWidth = (int)
 (currentHeight*imgWidth/imgHeight);
 > > }}}
 > > You already calculated the ratios and saved them in variables, no need
 to
 > > calculate them again here (and elsewhere!).
 > >
 >
 > I deleted the ratio variables because I found the syntax confusing due
 to additional type casting and needing more nested parentheses. This was
 included in the accidental-fixup commit, but I can revert this change if
 you think the ratio variables are more readable.

 Works for me. In that case please remove
 {{{
         final double imgDimensionRatioHeightWidth = imgHeight/imgWidth;
         final double imgDimensionRatioWidthHeight = imgWidth/imgHeight;
 }}}
 .

 [snip]

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28329#comment:94>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online