#27403: The onboarding bubble does not show up in the release candidate for Tor
Browser
--------------------------------------+--------------------------
Reporter: gk | Owner: tbb-team
Type: defect | Status: new
Priority: Immediate | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
--------------------------------------+--------------------------
Comment (by mcs):
I am not 100% sure that the root cause is the same as this bug, but
sometimes the onboarding bubble is not shown when I repeatedly press Cmd+T
on macOS after the first about:tor opens (to get more about:tor tabs). I
traced the problem to a zero window width inside the `_resizeUI()`
function within `browser/extensions/onboarding/content/onboarding.js`.
Interestingly, the problem disappears if I comment out the following
inside Torbutton's `src/chrome/skin/aboutTor.css` file:
{{{
body:not([initialized]) {
display: none;
}
}}}
My theory is that there is a race where sometimes the onboarding
extension's `_resizeUI()` function runs before about:tor has set the
`initialized` attribute on the body (so the document size is detected as
zero).
One possible way to fix this is to arrange for `_resizeUI()` to be called
a second (or third or ...) time if the document has a size of zero. I will
attach a *very* rough patch that fixes the problem for me. I am out of
time for tonight, but maybe Arthur or Georg can clean it up or find a
better solution. It would also be good to confirm that this is what is
occurring on Linux with the Tor Browser 8 RC.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27403#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online