[tbb-bugs] #25013 [Applications/Tor Browser]: Move TorButton code to the tor browser repository
Tor Bug Tracker & Wiki
blackhole at torproject.org
Tue Oct 30 13:30:13 UTC 2018
#25013: Move TorButton code to the tor browser repository
-----------------------------------------------+---------------------------
Reporter: igt0 | Owner: tbb-team
Type: defect | Status:
| needs_information
Priority: High | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: tbb-mobile, TorBrowserTeam201810R | Actual Points:
Parent ID: #10760 | Points:
Reviewer: gk, sysrqb, mcs, | Sponsor:
-----------------------------------------------+---------------------------
Changes (by gk):
* status: needs_review => needs_information
Comment:
`toolkit/` is fine. Some questions that came to mind while looking over
the changes
1) Do we really need the bug component part of the `moz.build` file? That
is meant for Mozilla's Bugzilla I think which we won't use anyway.
2) Why is it not enough to just have something like
`% locale torbutton @AB_CD@ %locale/@AB_CD@/`
but do
{{{
#if AB_CD == en_US
locale/@AB_CD@/ (src/chrome/locale/en/*)
#else
locale/@AB_CD@/ (src/chrome/locale/@AB_CD@/*)
#endif
}}}
and treat en-US like a special case?
3) I was wondering whether we should move the `jar.mn` and `moz.build`
files into the source directory given that essentially all extensions in
the Mozilla tree I have looked at have both at the same level as
`install.rdf.in`. Did you consider that?
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25013#comment:43>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tbb-bugs
mailing list