[tbb-bugs] #25013 [Applications/Tor Browser]: Move TorButton code to the tor browser repository

[Tor Bug Tracker & Wiki]

#25013: Move TorButton code to the tor browser repository
----------------------------------------------+--------------------------
 Reporter:  igt0                              |          Owner:  tbb-team
     Type:  defect                            |         Status:  new
 Priority:  High                              |      Milestone:
Component:  Applications/Tor Browser          |        Version:
 Severity:  Normal                            |     Resolution:
 Keywords:  tbb-mobile, TorBrowserTeam201810  |  Actual Points:
Parent ID:  #10760                            |         Points:
 Reviewer:  gk, sysrqb, mcs,                  |        Sponsor:
----------------------------------------------+--------------------------

Comment (by sysrqb):

 Replying to [comment:40 igt0]:
 > > > The next step is adding torbutton as submodule in the toolkit
 directory and update its moz.build file.
 > >
 > > I guess you have that outlined in your proposal but why toolkit and
 not the browser directory where all the other extensions are? Let's clear
 review for now as other, crucial pieces are missing. The review of the
 parts above might depend on them being available.
 > I would expect the browser/ directory be more about Desktop stuff. I can
 be totally wrong about it.

 Yes, I think toolkit is a better location for this, too. We shouldn't add
 torbutton under `browser/` if `mobile/` needs it (which it does). It seems
 like `toolkit/` is the directory for common browser functionality. If
 there is a better common directory, then I'm okay with using that, too.

 I'll add review comments soon.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25013#comment:41>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online