[tbb-bugs] #28051 [Applications/Tor Browser]: Build Orbot into TBA

[Tor Bug Tracker & Wiki]

#28051: Build Orbot into TBA
-------------------------------------------------+-------------------------
 Reporter:  sysrqb                               |          Owner:  sysrqb
     Type:  enhancement                          |         Status:
                                                 |  needs_review
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-mobile, tba-a2,                  |  Actual Points:
  TorBrowserTeam201811                           |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor8
-------------------------------------------------+-------------------------

Comment (by gk):

 Replying to [comment:37 sysrqb]:
 > Okay. I have two new branches, one for tor-browser and another for
 orbot.
 >
 > The orbot branch (`28051_orbot_4`) includes the changes in comment:31.
 It also includes a new proguard rule for keeping
 `org.torproject.android.settings.Languages.setup(Class,int)` that it was
 stipping due to it not being used. Unfortunately, this method is called by
 the Application when the app starts, so I added it in GeckoApplication in
 Fennec.
 >
 > I have mixed feelings about adding this, because on the one hand this is
 needed for opening Orbot's Settings menu - otherwise Orbot crashes and
 we're left with Tor Browser without Tor. However, on the other hand, we'll
 likely never use Orbot's settings menu. But, we're already renaming the
 preferences layout xml so it doesn't conflict with Fennec, so if we do
 that then I think it makes sense that we prevent this crash.

 I think that's okay and I agree with that.

 > The new tor-browser branch adds the necessary initialization calls -
 `28051_6`.

 Okay, both branches look good to me. I'll commit the `tor-browser` patches
 once we are good with all the other stuff.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28051#comment:40>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online