[tbb-bugs] #28640 [Applications/Tor Browser]: System addon does not override app-profile addon

[Tor Bug Tracker & Wiki]

#28640: System addon does not override app-profile addon
--------------------------------------+--------------------------
 Reporter:  sysrqb                    |          Owner:  tbb-team
     Type:  defect                    |         Status:  new
 Priority:  Very High                 |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  tbb-mobile                |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+--------------------------

Comment (by sysrqb):

 A fresh installation where torbutton is installed as a system addon look
 like this (I don't see any log entries where it is explicitly
 installed...but it is and it works):

 {{{
 11-28 02:19:07.403  8977  8994 D GeckoProfile: Created new profile dir.
 11-28 02:19:07.406  8977  8994 I GeckoProfile: Enqueuing profile init.
 11-28 02:19:07.408  8977  9000 E GeckoLibLoad: Load sqlite done
 11-28 02:19:07.408  8977  9000 E GeckoLibLoad: Load nss start
 11-28 02:19:07.408  8977  9000 E GeckoLibLoad: Load nss done
 11-28 02:19:07.409  8977  8994 D GeckoProfile: Found profile dir.
 11-28 02:19:07.409  8977  8994 D GeckoProfile: Attempting to write new
 client ID
 11-28 02:19:07.424  8977  8994 D GeckoDistribution: Creating
 /data/user/0/org.torproject.torbrowser_alpha/distribution/extensions
 11-28 02:19:07.474  8977  8977 D GeckoDistribution: Custom distribution
 directory not found.
 11-28 02:19:07.551  8977  8994 D GeckoDistribution: Getting file from
 distribution.
 11-28 02:19:07.563  8977  8994 D PostUpdateHandler: Build ID changed since
 last start: '20181128015826', 'null'
 11-28 02:19:07.563  8977  8994 D PostUpdateHandler: Copying system add-ons
 from APK to dataDir
 11-28 02:19:07.565  8977  8994 D PostUpdateHandler: Copying
 'features/torbutton at torproject.org.xpi' from APK to dataDir
 11-28 02:19:07.566  8977  8994 D PostUpdateHandler: Creating
 /data/user/0/org.torproject.torbrowser_alpha/features
 11-28 02:19:07.567  8977  8994 D GeckoSessInfo: Recording start of
 session: 1543371547435
 11-28 02:19:07.567  8977  8994 D GeckoDistribution: Getting file from
 distribution.
 11-28 02:19:07.567  8977  8994 E GeckoDistribution: Distribution
 preferences.json has no Global entry!
 11-28 02:19:07.568  8977  8994 D GeckoApplication: Running post-
 distribution task: bookmarks.
 11-28 02:19:07.568  8977  8994 D GeckoDistribution: Getting file from
 distribution.
 11-28 02:19:07.568  8977  8994 E GeckoDistribution: Distribution directory
 exists, but no file named bookmarks.json
 11-28 02:19:07.738  8977  8994 D GeckoApplication: Running post-
 distribution task: android preferences.
 11-28 02:19:07.738  8977  8994 D GeckoDistribution: Getting file from
 distribution.
 11-28 02:19:07.740  8977  8994 D GeckoDistribution: Getting file from
 distribution.
 11-28 02:19:07.745  8977  8994 D GeckoDistribution: Getting file from
 distribution.
 11-28 02:19:07.746  8977  8994 I GeckoSearchEngineManager: This is Tor
 Browser. Skipping.
 11-28 02:19:07.746  8977  8994 D GeckoSearchEngineManager: Found default
 engine name in browsersearch.json.
 11-28 02:19:07.746  8977  8994 D GeckoDistribution: Getting file from
 distribution.
 11-28 02:19:07.746  8977  8994 E GeckoDistribution: Distribution directory
 exists, but no file named searchplugins
 11-28 02:19:10.293  8977  9000 I Gecko   : 1543371550290        addons.xpi
 WARN    List of valid built-in add-ons could not be parsed.: [Exception...
 "Component returned failure code: 0x80520001
 (NS_ERROR_FILE_UNRECOGNIZED_PATH) [nsIXPCComponents_Utils.readUTF8URI]"
 nsresult: "0x80520001 (NS_ERROR_FILE_UNRECOGNIZED_PATH)"  location: "JS
 frame :: resource://gre/modules/addons/XPIProvider.jsm :: _readAddons ::
 line 6484"  data: no] Stack trace:
 _readAddons()@resource://gre/modules/addons/XPIProvider.jsm:6484
 11-28 02:19:10.293  8977  9000 I Gecko   :
 getAddonLocations()@resource://gre/modules/addons/XPIProvider.jsm:6145
 11-28 02:19:10.293  8977  9000 I Gecko   :
 getInstallState()@resource://gre/modules/addons/XPIProvider.jsm:1601
 11-28 02:19:10.293  8977  9000 I Gecko   :
 checkForChanges()@resource://gre/modules/addons/XPIProvider.jsm:3295
 11-28 02:19:10.293  8977  9000 I Gecko   :
 startup()@resource://gre/modules/addons/XPIProvider.jsm:2203
 11-28 02:19:10.293  8977  9000 I Gecko   :
 callProvider()@resource://gre/modules/AddonManager.jsm:258
 11-28 02:19:10.293  8977  9000 I Gecko   :
 _startProvider()@resource://gre/modules/AddonManager.jsm:733
 11-28 02:19:10.293  8977  9000 I Gecko   :
 startup()@resource://gre/modules/AddonManager.jsm:921
 11-28 02:19:10.293  8977  9000 I Gecko   :
 startup()@resource://gre/modules/AddonManager.jsm:3005
 11-28 02:19:10.293  8977  9000 I Gecko   :
 observe()@jar:jar:file:///data/app/org.torproject.torbrowser_alp
 11-28 02:19:10.394  8977  9000 D GeckoThread: State changed to
 PROFILE_READY
 11-28 02:19:10.898  8977  9000 D GeckoDistribution: Custom distribution
 directory not found.
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28640#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online