[tbb-bugs] #27977 [Applications/Tor Browser]: Build Orbot with rbm/tor-browser-build

[Tor Bug Tracker & Wiki]

#27977: Build Orbot with rbm/tor-browser-build
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-rbm, tbb-mobile,                 |  Actual Points:
  TorBrowserTeam201811R, TBA-a2                  |
Parent ID:  #26693                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by sisbell):

 Replying to [comment:38 gk]:


 > I built with the `tor-browser-60.3.0esr-8.5-1` branch and the latest
 patch for #27977 + put the patchset from sysrqb's `28051_3` on top of it.
 I'll get a compile error now:
 > {{{
 > 26:56.09
 :app:compileOfficialWithoutGeckoBinariesNoMinApiPhotonDebugJavaWithJavac/var/tmp/build
 /firefox-
 970fcfe56478/mobile/android/base/java/org/mozilla/gecko/notifications/NotificationHelper.java:38:
 error: cannot find symbol
 > 26:56.09 import
 org.torproject.android.service.util.[wiki:NotificationBuilderCompat];
 > 26:56.09                                           ^
 > 26:56.09   symbol:   class NotificationBuilderCompat
 > 26:56.09   location: package org.torproject.android.service.util
 > 26:56.09 /var/tmp/build/firefox-
 970fcfe56478/mobile/android/base/java/org/mozilla/gecko/notifications/NotificationClient.java:31:
 error: cannot find symbol
 > 26:56.09 import
 org.torproject.android.service.util.[wiki:NotificationBuilderCompat];
 > 26:56.09                                           ^
 > 26:56.09   symbol:   class NotificationBuilderCompat
 > 26:56.09   location: package org.torproject.android.service.util
 > 26:57.48 /var/tmp/build/firefox-
 970fcfe56478/mobile/android/base/java/org/mozilla/gecko/notifications/NotificationHelper.java:237:
 error: cannot find symbol
 > 26:57.48         final NotificationBuilderCompat builder = new
 NotificationBuilderCompat(mContext);
 > 26:57.48               ^
 > 26:57.48   symbol:   class NotificationBuilderCompat
 > 26:57.48   location: class NotificationHelper
 > 26:57.48 /var/tmp/build/firefox-
 970fcfe56478/mobile/android/base/java/org/mozilla/gecko/notifications/NotificationHelper.java:237:
 error: cannot find symbol
 > 26:57.48         final NotificationBuilderCompat builder = new
 NotificationBuilderCompat(mContext);
 > 26:57.48                                                       ^
 > 26:57.48   symbol:   class NotificationBuilderCompat
 > 26:57.48   location: class NotificationHelper
 > 26:57.48 /var/tmp/build/firefox-
 970fcfe56478/mobile/android/base/java/org/mozilla/gecko/notifications/NotificationClient.java:147:
 error: cannot find symbol
 > 26:57.48         final NotificationBuilderCompat builder = new
 NotificationBuilderCompat(mContext)
 > 26:57.48               ^
 > 26:57.48   symbol:   class NotificationBuilderCompat
 > 26:57.48   location: class NotificationClient
 > 26:57.48 /var/tmp/build/firefox-
 970fcfe56478/mobile/android/base/java/org/mozilla/gecko/notifications/NotificationClient.java:147:
 error: cannot find symbol
 > 26:57.48         final NotificationBuilderCompat builder = new
 NotificationBuilderCompat(mContext)
 > 26:57.48                                                       ^
 > 26:57.49   symbol:   class NotificationBuilderCompat
 > 26:57.49   location: class NotificationClient
 > 26:58.33 Note: Some input files use or override a deprecated API.
 > 26:58.33 Note: Recompile with -[Xlint:deprecation Xlint:deprecation] for
 details.
 > 26:58.33 6 errors
 > 26:58.33  FAILED
 > }}}

 Looks like your setup is out of sync (or perhaps something wasn't checked
 in). This was recently added to 28051_3. It adds the custom notification
 that your build log is saying its missing.


 {{{
 commit 4fd4234b10ee9af9dbd7e0d217135247f976015d
 Author: Matthew Finkel <Matthew.Finkel at gmail.com>
 Date:   Thu Nov 22 05:06:08 2018 +0000

     Bug 28051 - Use the custom notification compat impl

 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27977#comment:39>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online