[tbb-bugs] #28468 [Applications/Tor Browser]: Modify Android toolchain to support Orbot

[Tor Bug Tracker & Wiki]

#28468: Modify Android toolchain to support Orbot
-------------------------------------------------+-------------------------
 Reporter:  sisbell                              |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-rbm, tbb-mobile, TBA-a2,         |  Actual Points:
  TorBrowserTeam201811                           |
Parent ID:  #26693                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by sisbell):

 Replying to [comment:3 gk]:


 > Replying to [comment:1 sisbell]:
 >
 > > Changes (android-1115)
 > >
 > > * Changed NDK version used from 26 to 16 (this is only for building of
 rust)
 > >
 >
 > You mean this is for Orbot, right? Because that's what the commit
 message says and there is no Rust involvement into building Orbot. So, I
 think commit message needs to get updated at least.
 >
 You are right the api version has nothing to do with Orbot, only the new
 export variables in setup are for Orbot. I'll break apart the version
 issue into a separate ticket.

 > What speaks against hardcoding "16" as you did before and just adding a
 comment in the build script explaining the situation and what we are
 doing?

 I just added the var/standalone_ndk to make it more explicit. I'm ok
 either way, your call.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28468#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online