[tbb-bugs] #27443 [Applications/Tor Browser]: Update Firefox RBM config and build for Android

Tor Bug Tracker & Wiki blackhole at torproject.org
Thu Nov 15 19:14:52 UTC 2018


#27443: Update Firefox RBM config and build for Android
-------------------------------------------------+-------------------------
 Reporter:  sisbell                              |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-rbm, tbb-mobile, TBA-a2,         |  Actual Points:
  TorBrowserTeam201811                           |
Parent ID:  #26693                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by gk):

 Okay, I think that both problems you encountered are actual `libbacktrace`
 bugs. `libbacktrace` treats similar `dl_iterate_phdr` issues by making
 sure `HAVE_DL_ITERATE_PHDR` is not defined. That's essentially what the
 Rust folks did when updating `libbacktrace` for 1.28.0, so I think
 following that path is okay. I attached a patch for that.

 I am not sure yet what's up with `getpagesize` but I think your approach
 is right using `sysconf(_SC_PAGESIZE)` instead.

 Additionally, it seems we don't need the `ar` related option in
 `configure_opt` either. Could you remove that one (+ the linker related
 one) and add a `dl_iterate_phdr` + `getpagesize` patch in a separate
 commit? And on top of that one the one we thought for this bug? (I think
 everything you had was good, just the API line in the `mozconfig-android-
 armv7` file should go aswell).

 My current plan is to not spend more time on this issue (although it's
 weird that Mozilla did not run into those problems). I already shaved
 enough yaks to get that far. :)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27443#comment:68>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tbb-bugs mailing list