[tbb-bugs] #28051 [Applications/Tor Browser]: Build Orbot into TBA

Tor Bug Tracker & Wiki blackhole at torproject.org
Wed Nov 14 16:42:25 UTC 2018


#28051: Build Orbot into TBA
-------------------------------------------------+-------------------------
 Reporter:  sysrqb                               |          Owner:  sysrqb
     Type:  enhancement                          |         Status:
                                                 |  assigned
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-mobile, tba-a2,                  |  Actual Points:
  TorBrowserTeam201811                           |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by sysrqb):

 Replying to [comment:5 sysrqb]:
 > Okay. I spent a more than a few days troubleshooting a bug in Fennec
 this patch introduced. There is one more issue that remains and I'm not
 sure which direction we go with this right now (see
 ticket:27977#comment:12), I'll paste it here, as well for reference:
 >
 > > Right, this is a problem. We have two choices, and I don't
 particularly like either of them. Orbot doesn't need API 27 support, API
 26 is sufficient. However, we have a problem with the Android Support
 Library version it uses.
 >

 > > 1) We can downgrade the version of the support library Orbot depends
 on, and lose Notifications on Android O (and later version)
 > > 2) We can upgrade the version Fennec depends on and add a patch that
 changes the resource names.
 >

 Oh, and there is another problem I forgot to mention. Orbot's Onboarding
 screens are created using a third-party library
 ([https://github.com/paolorotolo/AppIntro/blob/master/appintro/build.gradle
 AppIntro]), and that library requires a the newest version of the Android
 support library (thus it causes the Material Design resource renaming
 issue). I think this is okay, and we can delete Orbot's Onboarding stuff
 and implement our own, depending on #28329. I'm assuming this is what we
 will do, for now.

 I also removed Orbot's dependency on
 [https://github.com/javiersantos/AppUpdater/blob/master/library/build.gradle
 AppUpdater] for the same reason, but this is a much less critical (and
 less invasive) component, so I'm not concerned about removing it.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28051#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tbb-bugs mailing list