[tbb-bugs] #28144 [Applications/Tor Browser]: Update projects/tor-browser for Android

[Tor Bug Tracker & Wiki]

#28144: Update projects/tor-browser for Android
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-rbm, tbb-mobile,                 |  Actual Points:
  TorBrowserTeam201811, TBA-a2                   |
Parent ID:  #26693                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by boklm):

 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:11 sisbell]:
 > Changes (android-1106)
 >
 >  * Added var/desktop field. Used to disable the projects that android
 doesn't need (if there is better way open to suggestions)

 I think you could use `! c("var/android")`.

 For a review of `2614830bb270321eaca0796587d1bd1a13295997`:
 * the build.android script is missing a `[% c("var/set_default_env") -%]`
 line at the begining
 * maybe `projects/firefox/build` could rename the apk files to a more
 predictible filename (for the desktop builds we use `tor-browser.tar.gz`)
 so that there is no need to use `find` in `projects/tor-
 browser/build.android` to find the filename.
 * I think that:
 {{{
 apkname='tor-browser-[% c("version") %]-[% c("var/osname") %].apk'
 [...]
 zip -r $apkname .
 cp $apkname [% dest_dir _ '/' _ c('filename') %]
 }}}
 could be replaced by:
 {{{
 zip -r '[% dest_dir %]/[% c('filename') %]/tor-browser-[% c("version")
 %]-[% c("var/osname") %].apk' .
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28144#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online